[MDL-32184] Turning off course edit while inside an activity or resource redirects (wrongly) to the course's front page - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2, 2.2.5, 2.3.2
Fix Version/s: 2.2.6, 2.3.3
Component/s: Course, Usability
Labels:
- gsoc2012
- patch
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
http://github.com/phalacee/moodle.git
Pull Master Branch:
wip-~~MDL-32184~~-master
Pull Master Diff URL:
https://github.com/phalacee/moodle/compare/master...wip-MDL-32184-master
Testing Instructions:
Hide

Log in as an admin

Create or use a course with an activity

Turn editing on at the course page

Open the Activity

From the course administration menu, select "Turn editing off"

Ensure you remain on the activity page.

From the course administration menu, select "Turn editing on"

Ensure you remain on the activity page.
Show
Log in as an admin Create or use a course with an activity Turn editing on at the course page Open the Activity From the course administration menu, select "Turn editing off" Ensure you remain on the activity page. From the course administration menu, select "Turn editing on" Ensure you remain on the activity page.

Description

Minor usability issue.

When course Edit mode is turned ON and while editing or viewing an Activity or a Resource,
I click on turn course editing off (setting block > course > editing off) ...
I am redirected to the course's front page and not to the page i was at when i clicked.

I am expecting to redirect to the same page i was at.

It seems, that the $fromurl is not used or has the wrong value.

Attachments

Issue Links

caused a regression

MDL-36674 Cannot edit my profile when HTTPS is turn on

Closed

MDL-36302 Return URL is incorrect on course editing page

Closed

Activity

People

Assignee:: Jason Fowler

Reporter:: Nadav Kavalerchik

Peer reviewer:: Frédéric Massart

Integrator:: Dan Poltawski

Tester:: David Monllaó

Participants:: Aparup Banerjee, Dan Poltawski, David Monllaó, Frédéric Massart, Jason Fowler, Kanika Goyal, Nadav Kavalerchik, Rajesh Taneja

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona), Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May, David Woloszyn, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 26/Mar/12 2:46 AM

Updated:: 30/Sep/13 9:08 PM

Resolved:: 19/Oct/12 5:25 AM

Fix Release Date:: 12/Nov/12