Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.5, 2.2.2, 2.3
-
Component/s: Questions
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-32213_manual_grade_question_upgrade
Description
The function 'get_converter_class_name' in '/question/engine/upgrade/upgradelib.php' is hard-coded to treat the question type 'essay' as manually-graded, when it should treat all manually-graded question types as manually-graded. I'm not sure quite how clear that last sentence was, so hopefully the fix is a bit clearer - change:
if ($question->qtype == 'essay') {
to:
$qtype = question_bank::get_qtype($question->qtype, false);
if ($qtype->is_manual_graded()) {
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
There you go, Tim.
It should cherry-pick fine to the other branches.
What testing have you done?
Can you write some testing instructions?
I've tested it by running a 1.9 => 2.2 upgrade several times with a custom question type, based on the essay type.
Added some testing instructions.
To INTEGRATORS:
Please cherry-pick to all branches 2.1+
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Tim, do you know if there are any manually graded question types to use for testing this which aren't the essay question type?
No. Sorry. Davo is clearly working on one, and reviewing the code change, it seems very low-risk to me.
I think what we really need to test is that Upgrade from 2.0 -> 2.1+ still works for standard Moodle essay qtypes. In other words, I think it is sufficient if we just test with essay. We can assume that what Davo has done, works for his 3rd party type.
Thanks, i've integrated this now.
Works fine - I upgraded from 2.0 to 2.2 ...
The code here has been spread to upstream moodle repositories and mirrors for anyone to use .
Closing, have a good weekend!
That looks good. How about a git branch that I can submit for integration?