Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32213

3rd party manually-graded question types do not upgrade properly

    Details

    • Testing Instructions:
      Hide

      Repeat for versions 2.1 and 2.2

      1. Set up a Moodle 2.0 site, create a quiz and add at least one essay question
      2. Log in as a student and attempt the quiz, answering all answers and submitting
      3. upgrade the site to Moodle [2.1 or 2.2]
      4. login as an admin/teacher and confirm that the question responses are present and that the questions are marked as being in need of manual grading
      Show
      Repeat for versions 2.1 and 2.2 Set up a Moodle 2.0 site, create a quiz and add at least one essay question Log in as a student and attempt the quiz, answering all answers and submitting upgrade the site to Moodle [2.1 or 2.2] login as an admin/teacher and confirm that the question responses are present and that the questions are marked as being in need of manual grading
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-32213_manual_grade_question_upgrade

      Description

      The function 'get_converter_class_name' in '/question/engine/upgrade/upgradelib.php' is hard-coded to treat the question type 'essay' as manually-graded, when it should treat all manually-graded question types as manually-graded. I'm not sure quite how clear that last sentence was, so hopefully the fix is a bit clearer - change:

      if ($question->qtype == 'essay') {

      to:

      $qtype = question_bank::get_qtype($question->qtype, false);
      if ($qtype->is_manual_graded()) {

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12