Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32218

Disabling Dock Does Not Restore Blocks When User Had All Blocks Docked

    Details

    • Testing Instructions:
      Hide

      1. Log in as a student and go to a course page that has multiple blocks in the left and right columns.
      2. Dock one block from the left column (example: dock Settings and leave Navigation undocked).
      3. Dock all the blocks in the right column.
      4. Log in as admin.
      5. Site administration > Appearance > Themes > Theme Settings. Uncheck "Allow blocks to use the dock" and save.
      6. Log in as the same student from above and return to the same course.
      7. Docks on both side should be restored.

      Show
      1. Log in as a student and go to a course page that has multiple blocks in the left and right columns. 2. Dock one block from the left column (example: dock Settings and leave Navigation undocked). 3. Dock all the blocks in the right column. 4. Log in as admin. 5. Site administration > Appearance > Themes > Theme Settings. Uncheck "Allow blocks to use the dock" and save. 6. Log in as the same student from above and return to the same course. 7. Docks on both side should be restored.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-32218

      Description

      When a user has some (but not all) blocks docked and an admin disables the dock, the user's docked blocks are restored as normal blocks. When a user has ALL blocks in a column docked and an admin disables the dock, the user's docked blocks from that column are not restored.

      I was able to reproduce this is in the latest version of 21_STABLE.

      Steps to reproduce:

      1. Log in as a student and go to a course page that has multiple blocks in the left and right columns.
      2. Dock one block from the left column (example: dock Settings and leave Navigation undocked).
      3. Dock all the blocks in the right column.
      4. Log in as admin.
      5. Site administration > Appearance > Themes > Theme Settings. Uncheck "Allow blocks to use the dock" and save.
      6. Log in as the same student from above and return to the same course.
      7. The one docked block from the left column will be restored to the left column but the docked blocks from the right column are nowhere to be found.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12