Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32232

When adding pages to a lesson, the text for adding a new question page from the drop down is inconsistent with the other pages

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.2
    • Fix Version/s: STABLE backlog
    • Component/s: Lesson
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      It simply says "Question" rather than "Add a question page"

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            saswatpadhi Saswat Padhi added a comment -

            I think this has been fixed in 22_STABLE.
            Screenshot attached.

            Show
            saswatpadhi Saswat Padhi added a comment - I think this has been fixed in 22_STABLE. Screenshot attached.
            Hide
            phalacee Jason Fowler added a comment -

            Saswat - this issue is about the text in the drop down on the previous page, not the button ..,

            Show
            phalacee Jason Fowler added a comment - Saswat - this issue is about the text in the drop down on the previous page, not the button ..,
            Hide
            saswatpadhi Saswat Padhi added a comment -

            Hi Jason ..
            Actually, when a lesson is created, it doesn't show a drop down, but just a list showing the options. I was confused with that.

            Now, I added a page to the lesson. Then tried to add another question page, and noticed it.

            STEPS TO REPLICATE:

            1. Create a new lesson in a course
            2. Add any page to the lesson
            3. Go back to the lesson home and try to edit the lesson
            4. Notice the dropdown "Add a new page"
            Show
            saswatpadhi Saswat Padhi added a comment - Hi Jason .. Actually, when a lesson is created, it doesn't show a drop down, but just a list showing the options. I was confused with that. Now, I added a page to the lesson. Then tried to add another question page, and noticed it. STEPS TO REPLICATE: Create a new lesson in a course Add any page to the lesson Go back to the lesson home and try to edit the lesson Notice the dropdown "Add a new page"
            Show
            saswatpadhi Saswat Padhi added a comment - Pull master Diff : https://github.com/SaswatPadhi/moodle/compare/master...MDL-32232 Pull MDL22 Diff : https://github.com/SaswatPadhi/moodle/compare/MOODLE_22_STABLE...MDL-32232_22
            Hide
            phalacee Jason Fowler added a comment -

            Saswat - thanks for that, I'm sure Rossi will appreciate the patch when she gets a chance to fix this

            Show
            phalacee Jason Fowler added a comment - Saswat - thanks for that, I'm sure Rossi will appreciate the patch when she gets a chance to fix this
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            Show
            rwijaya Rossiani Wijaya added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.
            Hide
            jmvedrine Jean-Michel Vedrine added a comment -

            The fix is just to change https://github.com/moodle/moodle/blob/master/mod/lesson/renderer.php#L418 from

            $options[0] = get_string('question', 'lesson');
            

            to:

            $options[0] = get_string('addaquestionpage', 'lesson');
            

            But obviously

            • it will make a lot of people unhappy because they will have to change their help documents, training videos ...
            • we will need to modify Moodle docs
            • a lot of lesson behat tests will be broken and will have to be modified

            I wonder if it's not too much work for just a little cosmetic change for consistency ?

            Show
            jmvedrine Jean-Michel Vedrine added a comment - The fix is just to change https://github.com/moodle/moodle/blob/master/mod/lesson/renderer.php#L418 from $options[0] = get_string('question', 'lesson'); to: $options[0] = get_string('addaquestionpage', 'lesson'); But obviously it will make a lot of people unhappy because they will have to change their help documents, training videos ... we will need to modify Moodle docs a lot of lesson behat tests will be broken and will have to be modified I wonder if it's not too much work for just a little cosmetic change for consistency ?

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: