[MDL-32234] invalid index error while browsing users with filter - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.1.5, 2.2.2, 2.3
Fix Version/s: 2.1.6, 2.2.3
Component/s: Forms Library
Labels:
- patch
- triaged

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Master Branch:
wip-mdl-32234
Pull Master Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-32234
Testing Instructions:
Hide

Log in as admin

Edit profile and change timezone to UTC (Can be any other then server time)

Browse users (Settings -> site administration -> Users -> accounts -> Browse list of users)

Add some filter text and press "Add filter"

no notice should appear.

Test 2:

Log in as admin

Edit profile and set timezone to UTC

Add calendar event for today at 00:00

Edit profile and set timezone to server time

Check today event, time should be properly shifted (for perth it should be 8:00 A.m.)

Now add another event and change timezone

make sure time is changed accordingly.

Test 3:
Run unit test: lib/simpletest/testmoodlelib.php on mac/linux/windows
If possible test different cases to make sure change in timezone works fine.
Show
Log in as admin Edit profile and change timezone to UTC (Can be any other then server time) Browse users (Settings -> site administration -> Users -> accounts -> Browse list of users) Add some filter text and press "Add filter" no notice should appear. Test 2: Log in as admin Edit profile and set timezone to UTC Add calendar event for today at 00:00 Edit profile and set timezone to server time Check today event, time should be properly shifted (for perth it should be 8:00 A.m.) Now add another event and change timezone make sure time is changed accordingly. Test 3: Run unit test: lib/simpletest/testmoodlelib.php on mac/linux/windows If possible test different cases to make sure change in timezone works fine.

Description

Note: turn debugging on.
Steps to reproduce:

Log in as admin
Edit profile and change timezone to UTC (Can be any other then server time)
Browse users (Settings -> site administration -> Users -> accounts -> Browse list of users)
Add some filter text and press "Add filter"
notice will appear.

FYI:
This is happening because usergetdate returns mon in two digits and select.php use strict matching.

Solution:
In dateselector.php typecase $currentdate['mon'] on line 153.
(int) $currentdate['mon'];

Attachments

Issue Links

has a non-specific relationship to

MDL-27562 Timezone option not considered in dateselector and datetimeselector form element

Closed

Activity

People

Assignee:: Rajesh Taneja

Reporter:: Rajesh Taneja

Peer reviewer:: Dan Poltawski

Integrator:: Eloy Lafuente (stronk7)

Tester:: Jason Fowler

Participants:: Aparup Banerjee, Dan Poltawski, Eloy Lafuente (stronk7), Jason Fowler, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 28/Mar/12 11:31 PM

Updated:: 30/Sep/13 6:16 PM

Resolved:: 06/May/12 1:41 AM

Fix Release Date:: 14/May/12