Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32234

invalid index error while browsing users with filter

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Edit profile and change timezone to UTC (Can be any other then server time)
      3. Browse users (Settings -> site administration -> Users -> accounts -> Browse list of users)
      4. Add some filter text and press "Add filter"
      5. no notice should appear.

      Test 2:

      1. Log in as admin
      2. Edit profile and set timezone to UTC
      3. Add calendar event for today at 00:00
      4. Edit profile and set timezone to server time
      5. Check today event, time should be properly shifted (for perth it should be 8:00 A.m.)
      6. Now add another event and change timezone
      7. make sure time is changed accordingly.

      Test 3:
      Run unit test: lib/simpletest/testmoodlelib.php on mac/linux/windows
      If possible test different cases to make sure change in timezone works fine.

      Show
      Log in as admin Edit profile and change timezone to UTC (Can be any other then server time) Browse users (Settings -> site administration -> Users -> accounts -> Browse list of users) Add some filter text and press "Add filter" no notice should appear. Test 2: Log in as admin Edit profile and set timezone to UTC Add calendar event for today at 00:00 Edit profile and set timezone to server time Check today event, time should be properly shifted (for perth it should be 8:00 A.m.) Now add another event and change timezone make sure time is changed accordingly. Test 3: Run unit test: lib/simpletest/testmoodlelib.php on mac/linux/windows If possible test different cases to make sure change in timezone works fine.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-32234
    • Pull Master Diff URL:

      Description

      Note: turn debugging on.
      Steps to reproduce:

      1. Log in as admin
      2. Edit profile and change timezone to UTC (Can be any other then server time)
      3. Browse users (Settings -> site administration -> Users -> accounts -> Browse list of users)
      4. Add some filter text and press "Add filter"
      5. notice will appear.

      FYI:
      This is happening because usergetdate returns mon in two digits and select.php use strict matching.

      Solution:
      In dateselector.php typecase $currentdate['mon'] on line 153.
      (int) $currentdate['mon'];

        Attachments

          Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-27562 Timezone option not considered in dateselector and datetimeselector form element

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Dan Poltawski Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Jason Fowler Jason Fowler
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12