Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32249

Hard coded string "% required" in course completion

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      To test:-
      Make sure course completion is enabled site-wide
      Create new course, enable completion
      Add Course Completion Status block to course
      Go to Completion settings for course, enable Course Grade criteria and enter a required grade with over 3 decimal places.
      Enrol student in course, and manually assign the student a grade via gradebook with a "long" grade e.g. 23.456743

      Old behaviour:
      Course Completion Status block, report doesn't round grades

      New behavour:
      Grades are rounded! (and whole numbers show no decimal places).

      Also, the "{$a} grade required" string in the block and report is no longer hardcoded in english.

      Show
      To test:- Make sure course completion is enabled site-wide Create new course, enable completion Add Course Completion Status block to course Go to Completion settings for course, enable Course Grade criteria and enter a required grade with over 3 decimal places. Enrol student in course, and manually assign the student a grade via gradebook with a "long" grade e.g. 23.456743 Old behaviour: Course Completion Status block, report doesn't round grades New behavour: Grades are rounded! (and whole numbers show no decimal places). Also, the "{$a} grade required" string in the block and report is no longer hardcoded in english.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
      git@github.com:srynot4sale/moodle.git
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Thoughout course completion report the string "xx% required" is hard coded. It is possible to see the issue in action setting "grade" and a required grade value as course completion criteria, then switching to a language other than English.

      The string also report a "%" sign, but this will be fixed seperately as part of MDL-31635.

      The wording and code surrounding grades is also rather inconsistent, so I have renamed the criteria to be "Course Grade" and changed instances of "Passing grade" to "Required grade" as completing a course != passing it.

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31635 Course completion "grade" criteria assume all grades are percentages

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              sry_not4sale Aaron Barnes
              Reporter:
              andreabix Andrea Bicciolo
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12