Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Rank:
      39034

      Description

      remaining E_STRICT issues:

      • unit tests for now run without E_STRICT

      to be verified:

      • messaging
      • pdflib
      • excel, csv export
      • all auth and enrol plugins

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Marina Glancy added a comment -

          Petr, I received the following warnings:

          Strict Standards: Declaration of data_field_file::update_content() should be compatible with that of data_field_base::update_content() in /var/www/repositories/master/moodle/mod/data/field/file/field.class.php on line 206
          
          Strict Standards: Declaration of data_field_picture::update_content() should be compatible with that of data_field_base::update_content() in /var/www/repositories/master/moodle/mod/data/field/picture/field.class.php on line 281
          

          not sure if you fixed it already in this issue.

          Show
          Marina Glancy added a comment - Petr, I received the following warnings: Strict Standards: Declaration of data_field_file::update_content() should be compatible with that of data_field_base::update_content() in / var /www/repositories/master/moodle/mod/data/field/file/field.class.php on line 206 Strict Standards: Declaration of data_field_picture::update_content() should be compatible with that of data_field_base::update_content() in / var /www/repositories/master/moodle/mod/data/field/picture/field.class.php on line 281 not sure if you fixed it already in this issue.
          Hide
          Petr Škoda added a comment -

          Marina: fixed together with other issues, thanks!!

          Show
          Petr Škoda added a comment - Marina: fixed together with other issues, thanks!!
          Hide
          Petr Škoda added a comment -

          to integrators: please integrate after MDL-32250

          Show
          Petr Škoda added a comment - to integrators: please integrate after MDL-32250
          Hide
          Sam Hemelryk added a comment -

          Hi Petr,

          A couple of notes I've made about this:

          • Should the spikephpcoverage changes be noted in its readme_moodle.txt
          • lib/completionlib.php has a non-static use of internal_get_grade_state still round line 576

          Other than spot on.
          I'll wait for you to comment on those two issues/patch them and then integrate this.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Petr, A couple of notes I've made about this: Should the spikephpcoverage changes be noted in its readme_moodle.txt lib/completionlib.php has a non-static use of internal_get_grade_state still round line 576 Other than spot on. I'll wait for you to comment on those two issues/patch them and then integrate this. Cheers Sam
          Hide
          Petr Škoda added a comment -

          Hi,

          patch pushed to my repo:

          • coverage - I must have been so happy that it does not need more E_STRICT hacking that I forgot to note the change, thanks!!
          • changed to self::internal_get_grade_state() - there are probably a lot more similar issues especially in gradebook. PHP does not care if you call static with valid $this, but I agree it is not a good coding style.

          Ciao.

          Show
          Petr Škoda added a comment - Hi, patch pushed to my repo: coverage - I must have been so happy that it does not need more E_STRICT hacking that I forgot to note the change, thanks!! changed to self::internal_get_grade_state() - there are probably a lot more similar issues especially in gradebook. PHP does not care if you call static with valid $this, but I agree it is not a good coding style. Ciao.
          Hide
          Sam Hemelryk added a comment -

          Looks like Eloy just beat me to integrating this. Thanks for tiding those thing up Petr

          Show
          Sam Hemelryk added a comment - Looks like Eloy just beat me to integrating this. Thanks for tiding those thing up Petr
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing tests, I've added one extra commit fixing 2 more E_STRICT occurrences. But all tests are passing both here and under the CI server.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing tests, I've added one extra commit fixing 2 more E_STRICT occurrences. But all tests are passing both here and under the CI server.
          Hide
          Aparup Banerjee added a comment -

          The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

          Closing, have a good weekend!

          Show
          Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: