Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32253

Add link to forum discussion in emails notification in text format

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.6
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      • Create course in moodle as default
      • Enrol a user in a course
      • Edit this user profile and set "email format" to "plain text format"
      • Create a discussion in the news forum and add a post
      • User will receive email with correct head, body, link to reply, link to unsubscribe, but no link to view the post or discussion

      If you apply the patch and repeat test instructions you will have an email with everything plus a link to view the discussion.

      Show
      Create course in moodle as default Enrol a user in a course Edit this user profile and set "email format" to "plain text format" Create a discussion in the news forum and add a post User will receive email with correct head, body, link to reply, link to unsubscribe, but no link to view the post or discussion If you apply the patch and repeat test instructions you will have an email with everything plus a link to view the discussion.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-32253-master

      Description

      The email notification of users posts in forums contains the link for the discussion only in html mode. Users that prefer text emails (linke me have to click on the reply link, get a "you have to login", click in a button and login just to view the discussion (because it is easier to login in this case even if the discussion does not require authentication to read).

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            danielneis Daniel Neis added a comment -

            Hello,

            i've submitted a pull request in github. Here's the link to diff: https://github.com/danielneis/moodle/compare/MDL-32253

            HTH,
            Daniel

            Show
            danielneis Daniel Neis added a comment - Hello, i've submitted a pull request in github. Here's the link to diff: https://github.com/danielneis/moodle/compare/MDL-32253 HTH, Daniel
            Hide
            salvetore Michael de Raadt added a comment -

            "Users that prefer text emails (like me)": That's committment

            I'm not sure exactly what you mean by having to log in. If someone wasn't already logged in, they would usually need to do that regardless.

            But I think your change will be beneficial. Thanks for providing a patch with that.

            Show
            salvetore Michael de Raadt added a comment - "Users that prefer text emails (like me)": That's committment I'm not sure exactly what you mean by having to log in. If someone wasn't already logged in, they would usually need to do that regardless. But I think your change will be beneficial. Thanks for providing a patch with that.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Daniel,

            Thanks for your patch - I like it.

            I would like to submit this issue for integration, are you able to rebase your branch and provide testing instructions for this change?

            Show
            poltawski Dan Poltawski added a comment - Hi Daniel, Thanks for your patch - I like it. I would like to submit this issue for integration, are you able to rebase your branch and provide testing instructions for this change?
            Hide
            danielneis Daniel Neis added a comment -

            Hello,

            i've rebased the branch https://github.com/danielneis/moodle/tree/MDL-32253

            Hope you like.

            Regards,
            Daniel

            Show
            danielneis Daniel Neis added a comment - Hello, i've rebased the branch https://github.com/danielneis/moodle/tree/MDL-32253 Hope you like. Regards, Daniel
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Daniel,

            Thanks, for some reason your rebase didn't seem quite right so I have pulled your commit and rebased it onto a branch and i'm submitting for integration.

            As an improvement this will only go into the master branch.

            Show
            poltawski Dan Poltawski added a comment - Hi Daniel, Thanks, for some reason your rebase didn't seem quite right so I have pulled your commit and rebased it onto a branch and i'm submitting for integration. As an improvement this will only go into the master branch.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys - this has been integrated now
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            works as described.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - works as described. Thanks
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            I did find MDL-40229 during testing

            Show
            ankit_frenz Ankit Agarwal added a comment - I did find MDL-40229 during testing
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for your contributions!

            _main:
            @ BB#0:
                    push    {r7, lr}
                    mov     r7, sp
                    sub     sp, #4
                    movw    r0, :lower16:(L_.str-(LPC0_0+4))
                    movt    r0, :upper16:(L_.str-(LPC0_0+4))
            LPC0_0:
                    add     r0, pc
                    bl      _printf
                    movs    r1, #0
                    movt    r1, #0
                    str     r0, [sp]                @ 4-byte Spill
                    mov     r0, r1
                    add     sp, #4
                    pop     {r7, pc}
             
                    .section        __TEXT,__cstring,cstring_literals
            L_.str:                                 @ @.str
                    .asciz   "This code is now upstream!"
            

            Show
            poltawski Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4-byte Spill mov r0, r1 add sp, #4 pop {r7, pc}   .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13