Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32256

quiz_cron() not returning true

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires DB access)

      1. Execute cron
      2. Check the value of the lastcron field in mdl_modules for the module 'quiz'
      3. TEST: make sure the value is greater than 0

      Show
      Testing difficulty: medium (requires DB access) 1. Execute cron 2. Check the value of the lastcron field in mdl_modules for the module 'quiz' 3. TEST: make sure the value is greater than 0
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32256-cron-return

      Description

      (15:10:15) david: timhunt: are you aware of quiz_cron() not returning true, hence mdl_modules::lastcron still set to 0 ? Intentional?
      (15:10:43) david: does not matter much as it is set to run @60 (== every minute)
      (15:10:52) david: but
      (15:11:00) timhunt: Grrr!
      (15:11:01) timhunt: No.
      (15:11:08) timhunt: WTF.
      (15:11:21) timhunt: When does Moodlre ely on return true/false any more.
      (15:11:33) timhunt: I thought we were meant to throw exceptions on error.
      (15:11:42) david: well, it just executes at every cron.php execution
      (15:11:56) david: which can't be more often than every minute anyway
      (15:12:14) timhunt: Yes. But still.
      (15:12:15) david: but I can imagine some internal checks against lastcron (to warn admin, for example)
      (15:12:17) david: Yes.
      (15:12:26) timhunt: Would you like to fix this? Or at least file a bug for me?
      (15:12:36) david: willco
      (15:12:45) timhunt: Thanks.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12