Moodle

mod_data requires cron every minute without providing data_cron() function

Details

  • Testing Instructions:
    Hide

    Testing difficulty: medium (requires DB access)

    1. Upgrade (make sure that mod_data is upgraded)
    2. Check mdl_modules table in the DB
    3. TEST: Make sure that the 'cron' field for the 'data' module is set to 0

    Show
    Testing difficulty: medium (requires DB access) 1. Upgrade (make sure that mod_data is upgraded) 2. Check mdl_modules table in the DB 3. TEST: Make sure that the 'cron' field for the 'data' module is set to 0
  • Affected Branches:
    MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-32258-data-cron
  • Pull Master Diff URL:

Description

This effectively means that cron_run() loads mod/data/lib.php for no reason on every cron execution.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

Submitting for integration.

Show
David Mudrak added a comment - Submitting for integration.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Thanks David, this has been integrated now

Show
Sam Hemelryk added a comment - Thanks David, this has been integrated now
Hide
Permalink
Adrian Greeve added a comment -

I checked the databases for 2.1, 2.2 and master. The cron field has been set to 0 in mdl_modules data field.
Thanks.

Show
Adrian Greeve added a comment - I checked the databases for 2.1, 2.2 and master. The cron field has been set to 0 in mdl_modules data field. Thanks.
Hide
Permalink
Aparup Banerjee added a comment -

The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

Closing, have a good weekend!

Show
Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: