Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32262

Missing comma in afterburner theme CSS

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Themes
    • Labels:

      Description

      in afterburner_styles.css at approx line 221 there is a missing comma after:

      .coursebox h3

      which causes the Course names to not use the full 100% of the width while the summaries are forced onto the next line by using 100% (I believe the original intent was to place course title on one line and summary on the next).

      Proposal: add comma to the end of the line.

      Regards - Keith.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for spotting that and suggesting a solution.

            I can confirm this is still in the current master.

            Show
            salvetore Michael de Raadt added a comment - Thanks for spotting that and suggesting a solution. I can confirm this is still in the current master.
            Hide
            lazydaisy Mary Evans added a comment -

            Well spotted! Thanks will fix today...

            Show
            lazydaisy Mary Evans added a comment - Well spotted! Thanks will fix today...
            Hide
            lazydaisy Mary Evans added a comment -

            Fixing in progress

            Show
            lazydaisy Mary Evans added a comment - Fixing in progress
            Hide
            lazydaisy Mary Evans added a comment -

            @Michael,
            Can you confirm that MOODLE_22_STABLE & MOODLE_21_STABLE branches have been updated?
            I need to be in a position to 'fast forward' before I create a local branch for this patch. Just wanting to save myself having to re-base later if they haven't.
            Thanks
            Mary

            Show
            lazydaisy Mary Evans added a comment - @Michael, Can you confirm that MOODLE_22_STABLE & MOODLE_21_STABLE branches have been updated? I need to be in a position to 'fast forward' before I create a local branch for this patch. Just wanting to save myself having to re-base later if they haven't. Thanks Mary
            Hide
            lazydaisy Mary Evans added a comment -

            This is a CSS fix so no testing needed.

            Show
            lazydaisy Mary Evans added a comment - This is a CSS fix so no testing needed.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Mary changes are spot on - this has been integrated now (first issue of the week I believe)

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Mary changes are spot on - this has been integrated now (first issue of the week I believe)
            Hide
            salvetore Michael de Raadt added a comment -

            I think it is still worth checking that this change has been effective.

            Show
            salvetore Michael de Raadt added a comment - I think it is still worth checking that this change has been effective.
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success.

            Tested in 2.1, 2.2 and master.

            After changing the theme to Afterburner I was able to see the style correctly applied to H3, info and summary elements with course information on the site home page.

            Show
            salvetore Michael de Raadt added a comment - Test result: Success. Tested in 2.1, 2.2 and master. After changing the theme to Afterburner I was able to see the style correctly applied to H3, info and summary elements with course information on the site home page.
            Hide
            nebgor Aparup Banerjee added a comment -

            The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

            Closing, have a good weekend!

            Show
            nebgor Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12