Moodle
  1. Moodle
  2. MDL-32285

Added "Continue" button under Error notification message (IMS CP)

    Details

    • Type: Improvement Improvement
    • Status: Waiting for peer review
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.2, 2.8.3
    • Fix Version/s: None
    • Component/s: IMS-CP resource type
    • Labels:

      Description

      After uploading a problematic (bad or no manifest.xml file) IMS CP file (package)
      I am getting an error message with no continue button.
      It seems like a minor usability issue.

      Adding a "Continue" button with a link to the course's main page could be very helpful to novice teachers.
      Attached, is a proposed fix.

      EDIT:
      For testing purposes, I am attaching two IMS CP packages, One with bad (missing) manifest file and one which is perfectly OK.

        Gliffy Diagrams

        1. imscp-error.png
          29 kB

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for suggesting that.

          As always, feel free to work on this with us.

          Show
          Michael de Raadt added a comment - Thanks for suggesting that. As always, feel free to work on this with us.
          Hide
          Marina Glancy added a comment -

          We have detected that this issue has been inactive for over two years and also did not collect many votes. It is possible that it has been already implemented in a more recent version of Moodle, or it is not highly demanded. There are unlimited number of ways Moodle functinality can be expanded and improved but we would like to concentrate on the features that will benefit majority of users, and which can not be implemented as plugins. If you have a suggestion for improving Moodle core, and there is no open issue for it in the tracker, please start a new forum discussion to see how many other users agree with you, and then create a new issue providing as many details as possible.

          ==BLK2YIMP20141121==

          Show
          Marina Glancy added a comment - We have detected that this issue has been inactive for over two years and also did not collect many votes. It is possible that it has been already implemented in a more recent version of Moodle, or it is not highly demanded. There are unlimited number of ways Moodle functinality can be expanded and improved but we would like to concentrate on the features that will benefit majority of users, and which can not be implemented as plugins. If you have a suggestion for improving Moodle core, and there is no open issue for it in the tracker, please start a new forum discussion to see how many other users agree with you, and then create a new issue providing as many details as possible. ==BLK2YIMP20141121==
          Hide
          Nadav Kavalerchik added a comment -

          Hi Marina Glancy, I think you were too quick to close this one.
          This is some kind of a "bug" in the UI workflow.

          The suggested 1 line patch, can solve it nicely by adding a button.
          Please see if you can reopen and apply.

          Show
          Nadav Kavalerchik added a comment - Hi Marina Glancy , I think you were too quick to close this one. This is some kind of a "bug" in the UI workflow. The suggested 1 line patch, can solve it nicely by adding a button. Please see if you can reopen and apply.
          Hide
          Marina Glancy added a comment -

          Sure, here you go. Added the missing 'patch' label as well.
          If anybody wants to submit the patch as a git branch with testing instructions - you are more than welcome.

          Show
          Marina Glancy added a comment - Sure, here you go. Added the missing 'patch' label as well. If anybody wants to submit the patch as a git branch with testing instructions - you are more than welcome.
          Hide
          Nadav Kavalerchik added a comment -

          Original IMS CP packages are from: http://www.elml.org/website/en/html/output_cp.html

          Show
          Nadav Kavalerchik added a comment - Original IMS CP packages are from: http://www.elml.org/website/en/html/output_cp.html
          Hide
          Nadav Kavalerchik added a comment -

          Ready for peer review.

          Show
          Nadav Kavalerchik added a comment - Ready for peer review.
          Hide
          CiBoT added a comment -
          Show
          CiBoT added a comment - Fails against automated checks. Checked MDL-32285 using repository: https://github.com/nadavkav/moodle/ master (1 errors / 0 warnings) [branch: MDL-32285_master | CI Job ] phplint (0/0) , php (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/0) , savepoint (0/0) , thirdparty (0/0) , More information about this report

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: