Moodle
  1. Moodle
  2. MDL-32286

$string['uploadextension']: ambiguous statement in EN lang pack

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.17, 2.1, 2.2
    • Fix Version/s: 2.1.7, 2.2.4, 2.3.1
    • Component/s: Language
    • Labels:

      Description

      The string currently used in case of UPLOAD_ERR_EXTENSION:

      $string['uploadextension'] = 'File upload stopped by extension'

      can lead to kind of misunderstandings, the user can think at the file extension rather than to a PHP extension.
      It should be something like:

      $string['uploadextension'] = 'File upload stopped by a PHP extension'

      according with http://php.net/manual/en/features.file-upload.errors.php:

      UPLOAD_ERR_EXTENSION

      Value: 8; A PHP extension stopped the file upload. PHP does not provide a way to ascertain which extension caused the file upload to stop; examining the list of loaded extensions with phpinfo() may help. Introduced in PHP 5.2.0.

        Gliffy Diagrams

        1. patch.txt
          0.8 kB
          Yevhenii Vlasenko

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Thanks for suggesting that.

            Show
            Michael de Raadt added a comment - Thanks for suggesting that.
            Hide
            Yevhenii Vlasenko added a comment -

            Fixed

            Show
            Yevhenii Vlasenko added a comment - Fixed
            Hide
            Ankit Agarwal added a comment -

            Hi guys,
            This looks good.
            Can be back-ported in my opinion.
            Thanks

            Show
            Ankit Agarwal added a comment - Hi guys, This looks good. Can be back-ported in my opinion. Thanks
            Hide
            Matteo Scaramuccia added a comment -

            Added the original forum post, even if in Italian. Long story short: an incorrect Moodle error message hides the real issue, the mis-configuration of ConfigServer eXploit Scanner integrated with Suhosin through suhosin.upload.verification_script.

            Show
            Matteo Scaramuccia added a comment - Added the original forum post, even if in Italian. Long story short: an incorrect Moodle error message hides the real issue, the mis-configuration of ConfigServer eXploit Scanner integrated with Suhosin through suhosin.upload.verification_script .
            Hide
            Sam Hemelryk added a comment -

            Thanks guys, this has been integrated now and backported to stable branches.

            Show
            Sam Hemelryk added a comment - Thanks guys, this has been integrated now and backported to stable branches.
            Hide
            Sam Hemelryk added a comment -

            Confirmed changed

            Show
            Sam Hemelryk added a comment - Confirmed changed
            Hide
            Sam Hemelryk added a comment -

            Congratulations your code is upstream - gold star for you!

            This issue + 79 others made it in in time for the minor releases.
            Thank you everyone involved for your exuberant efforts.

            Show
            Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: