Moodle
  1. Moodle
  2. MDL-32293

Consider moving the upgrade_set_timeout() function to lib/upgradelib.php

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Installation, Libraries
    • Labels:
    • Rank:
      39088

      Description

      While documenting the Upgrade API (MDL-30981), it has been noticed that the upgrade_set_timeout() function is the only one belonging to that API and not being @ lib/upgradelib.php. Right now it sits @ lib/moodlelib.php.

      So perhaps it would be interesting to move it, so the whole API is in its own lib file.

      Ciao

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          I have reviewed all places that use this function, all of them are in db/upgrade.php's or obsolte _grade_upgrade module functions.

          Thanks for spotting this!

          Show
          Petr Škoda added a comment - I have reviewed all places that use this function, all of them are in db/upgrade.php's or obsolte _grade_upgrade module functions. Thanks for spotting this!
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr, integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Petr, integrated now.
          Hide
          Jason Fowler added a comment -

          Update went through perfectly

          Show
          Jason Fowler added a comment - Update went through perfectly
          Hide
          Dan Poltawski added a comment -

          Jolly good show!

          Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

          Tally-ho!

          Show
          Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: