Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32293

Consider moving the upgrade_set_timeout() function to lib/upgradelib.php

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Installation, Libraries
    • Labels:

      Description

      While documenting the Upgrade API (MDL-30981), it has been noticed that the upgrade_set_timeout() function is the only one belonging to that API and not being @ lib/upgradelib.php. Right now it sits @ lib/moodlelib.php.

      So perhaps it would be interesting to move it, so the whole API is in its own lib file.

      Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              I have reviewed all places that use this function, all of them are in db/upgrade.php's or obsolte _grade_upgrade module functions.

              Thanks for spotting this!

              Show
              skodak Petr Skoda added a comment - I have reviewed all places that use this function, all of them are in db/upgrade.php's or obsolte _grade_upgrade module functions. Thanks for spotting this!
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Petr, integrated now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Petr, integrated now.
              Hide
              phalacee Jason Fowler added a comment -

              Update went through perfectly

              Show
              phalacee Jason Fowler added a comment - Update went through perfectly
              Hide
              poltawski Dan Poltawski added a comment -

              Jolly good show!

              Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

              Tally-ho!

              Show
              poltawski Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12