Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32301

LTI Tools don't allow instructor custom parameters

    Details

    • Testing Instructions:
      Hide
      1. Create an External Tool item (You can use a launch URL from https://lti-examples.heroku.com/index.html)
      2. Make sure Advanced options are shown, then enter something into the Custom Parameters field (like test=testing)
      3. Save the External Tool item, and open your favorite web inspector (Firebug, Chrome inspector, etc.)
      4. Perform a launch of the External Tool, and check the post data. You should see a custom_test=testing parameter passed in the launch (Look for launch.php under the network tab)
      Show
      Create an External Tool item (You can use a launch URL from https://lti-examples.heroku.com/index.html ) Make sure Advanced options are shown, then enter something into the Custom Parameters field (like test=testing) Save the External Tool item, and open your favorite web inspector (Firebug, Chrome inspector, etc.) Perform a launch of the External Tool, and check the post data. You should see a custom_test=testing parameter passed in the launch (Look for launch.php under the network tab)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-32301_lti_instructor_params

      Description

      In the launch code, if allowinstructorcustom is blank or set to "never", the instructor is not allowed to supply their own custom parameters. When tool configurations are written, the allowinstructorcustom setting is left blank.

      We should change the behavior to allow custom parameters if allowinstructorcustom is not set, as there is not really a good reason to restrict people from editing them.

      Note that some tool providers require information in the custom parameters to indicate which resource should be launched and will not work until this is resolved. This will be a major issue for some tool providers.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/13