Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32310

mediaplugin mp3 player not shown in chrome

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Filters
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable the multimedia filter
      2. Use chrome
      3. Add/ enable the screenshot extension (https://chrome.google.com/webstore/detail/cpngackimfmofbokmjmljamhdncknpmg)
      4. Create a forum post and use the add media button to add an mp3
      5. View your forum post
      6. The forum post should contain the little flash media player (NOTE: on my chrome when it was breaking it was falling back to the OSX inbuilt media player, however this would break badly in other oses)
      Show
      Enable the multimedia filter Use chrome Add/ enable the screenshot extension ( https://chrome.google.com/webstore/detail/cpngackimfmofbokmjmljamhdncknpmg ) Create a forum post and use the add media button to add an mp3 View your forum post The forum post should contain the little flash media player (NOTE: on my chrome when it was breaking it was falling back to the OSX inbuilt media player, however this would break badly in other oses)
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      When loading a page with an mp3 file and mediaplugin enabled, chrome is not displaying the player.
      Looking at the chrome javascript console it seems to be because of the way document.styleSheet is iterated.
      Each rule is tested like this:

      typeof (document.styleSheets[j].rules) != 'undefined'

      but in chrome the last .rules is = null. A simple check can deal with this:

      if (!allrules) continue;

      (after the "if" and before the "for").

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              drphrozen Esben Sune Rasmussen
              Integrator:
              Sam Hemelryk
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Sep/12