Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32321

Autolink class is missing from "Formal White" theme in Moodle 2.2

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Enable filter "Activity names auto-linking".
      Add an activity.
      Write somewhere in moodle pages (let's say in the course description) the name of the just added activity.
      Moodle should automatically create a link to that activity with the autolink class.
      That link is supposed to be underlined to let user understand it is a link and not a simple plain text.

      Test also the last minute change: go to the notification page. The box with admin warning about maturity info should now have a green background color.

      Show
      Enable filter "Activity names auto-linking". Add an activity. Write somewhere in moodle pages (let's say in the course description) the name of the just added activity. Moodle should automatically create a link to that activity with the autolink class. That link is supposed to be underlined to let user understand it is a link and not a simple plain text. Test also the last minute change: go to the notification page. The box with admin warning about maturity info should now have a green background color.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32321_master

      Description

      The autolink class is missing from style/core.css in the "Formal White" theme in Moodle 2.2. This means that links within texts are not properly distinguished as links. They simply look the same as the rest of the text unless you roll over them. The fix is to simply add "a.autolink

      color: Color value is invalid

      to the end of theme/formal_white/style/core.css.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            lazydaisy Mary Evans added a comment -

            @Daniele
            I have just assigned this 'bug' to you as I thought you would be the best person to fix it.

            Show
            lazydaisy Mary Evans added a comment - @Daniele I have just assigned this 'bug' to you as I thought you would be the best person to fix it.
            Hide
            daniss Daniele Cordella added a comment -

            The fix is trivial but the problem I am facing is different.
            I can not find any occurrence of anchor with class='autolink' browsing moodle.
            Can anyone help me to check the classes that I am adding?
            Thanks in advance.

            Show
            daniss Daniele Cordella added a comment - The fix is trivial but the problem I am facing is different. I can not find any occurrence of anchor with class='autolink' browsing moodle. Can anyone help me to check the classes that I am adding? Thanks in advance.
            Hide
            daniss Daniele Cordella added a comment -

            Paul, can you please tell me where did you find links with autolink class?
            Thanks in advance.

            Show
            daniss Daniele Cordella added a comment - Paul, can you please tell me where did you find links with autolink class? Thanks in advance.
            Hide
            pallthayer Paul Thayer added a comment -

            Daniele, the "autolinks" show up when you type the title of a course resource in a text. I.e. If I have a quiz activity named "First test", if I type "First test" in a summary, Moodle will automatically create a link to that activity with the autolink class.

            Show
            pallthayer Paul Thayer added a comment - Daniele, the "autolinks" show up when you type the title of a course resource in a text. I.e. If I have a quiz activity named "First test", if I type "First test" in a summary, Moodle will automatically create a link to that activity with the autolink class.
            Hide
            daniss Daniele Cordella added a comment -

            Thanks Paul
            I just added the missing class as of your suggestion.

            Show
            daniss Daniele Cordella added a comment - Thanks Paul I just added the missing class as of your suggestion.
            Hide
            daniss Daniele Cordella added a comment -

            @Mary: Can I ask you, please, to review this issue and MDL-32380?
            As far as I can see, the total needed time should be lower than 10 minutes.
            Thanks in advance.

            Show
            daniss Daniele Cordella added a comment - @Mary: Can I ask you, please, to review this issue and MDL-32380 ? As far as I can see, the total needed time should be lower than 10 minutes. Thanks in advance.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Daniele,

            I have integrated this now. I noticed there was a change related to the admin plugins css. I integrated this anyway because it seemed sensible. Please could you update the testing instructions to incldue this change though.

            Show
            poltawski Dan Poltawski added a comment - Hi Daniele, I have integrated this now. I noticed there was a change related to the admin plugins css. I integrated this anyway because it seemed sensible. Please could you update the testing instructions to incldue this change though.
            Hide
            daniss Daniele Cordella added a comment -

            Thanks Dan, I just modified the testing instructions

            Show
            daniss Daniele Cordella added a comment - Thanks Dan, I just modified the testing instructions
            Hide
            fred Frédéric Massart added a comment -

            Test successful on master

            Show
            fred Frédéric Massart added a comment - Test successful on master
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            U P S T R E A M I Z E D !

            Many thanks for the hard work, closing this as fixed.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12