Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32325

Glossary entry printing is not XHTML compliant and does not permit theming

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Glossary, Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a new glossary with 'Entry list' as display format
      2. Add a few entries to the glossary
      3. Go back to the main page of the glossary
      4. Click on the print icon on the top right
      5. Check that: the concepts and definitions appear nicely on the page
      6. Check that: the divs for each glossary entry have distinct classes to allow easy theming. The divs inside the glossary entry must have a distinct class as well.
      7. Apply steps 3 to 6 to a few other themes.

      Show
      1. Create a new glossary with 'Entry list' as display format 2. Add a few entries to the glossary 3. Go back to the main page of the glossary 4. Click on the print icon on the top right 5. Check that: the concepts and definitions appear nicely on the page 6. Check that: the divs for each glossary entry have distinct classes to allow easy theming. The divs inside the glossary entry must have a distinct class as well. 7. Apply steps 3 to 6 to a few other themes.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32325-master

      Description

      The output of an entry when you click the print icon on a glossary is...

      <b><h3 class="nolink"><span class="nolink">Concept</span></h3>:</b> <div class="no-overflow"><span class="nolink"></span><p>Description a dgasd gdasd gsag</p></div>

      The <b> tag should not be used and the concept title (using <h3> and <span> should be a div with a class that is set in the base theme. Also the description <div> should have a class that is set in the base theme.

      Also, the colon (:) is not needed and make the output look silly. It should be removed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              salvetore Michael de Raadt
              Peer reviewer:
              Andrew Davis
              Integrator:
              Sam Hemelryk
              Tester:
              Sam Hemelryk
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12