Moodle
  1. Moodle
  2. MDL-32337

Be more cautious about saying 'your moodle is up to date'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Difficult: HARD - requires manual DB queries

      1. Simulate no update data yet by doing: DELETE FROM mdl_config_plugins where plugin = 'core_plugin';
      2. Simulate outdated update data by doing': UPDATE mdl_config_plugins set value = '1' WHERE name = 'recentfetch' AND plugin = 'core_plugin';
      Show
      Difficult: HARD - requires manual DB queries Simulate no update data yet by doing: DELETE FROM mdl_config_plugins where plugin = 'core_plugin'; Simulate outdated update data by doing': UPDATE mdl_config_plugins set value = '1' WHERE name = 'recentfetch' AND plugin = 'core_plugin';
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32337-uptodate
    • Rank:
      39158

      Description

      Currently its displaying 'Your moodle code seems to be up-to-date' when it has no fetch data at all or if the fetch data is highly outdated.

      In those cases I think it should only display 'check for available updates'. For sure there are going to be people where they haven't the proxy configured correctly or whatever and moodle can't get the update check so we shouldn't be reporting this.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Example screenshot

          Show
          Dan Poltawski added a comment - Example screenshot
          Hide
          David Mudrak added a comment -

          Very well spotted Dan! I did not realize this when writing this initially. I used the similar check to what available_update_checker::cron_has_fresh_fetch() does. Now the message 'Your Moodle code is up-to-date!' is displayed if and only if a) we have actually fetched something and b) the fetch was done in the last hour.

          From usability point of view, the message is now displayed as a response to pressing the button which looks ok to me.

          Submitting for integration.

          Show
          David Mudrak added a comment - Very well spotted Dan! I did not realize this when writing this initially. I used the similar check to what available_update_checker::cron_has_fresh_fetch() does. Now the message 'Your Moodle code is up-to-date!' is displayed if and only if a) we have actually fetched something and b) the fetch was done in the last hour. From usability point of view, the message is now displayed as a response to pressing the button which looks ok to me. Submitting for integration.
          Hide
          Sam Hemelryk added a comment -

          Integrated thanks David!

          Show
          Sam Hemelryk added a comment - Integrated thanks David!
          Hide
          Frédéric Massart added a comment -

          Successfully tested on master

          Show
          Frédéric Massart added a comment - Successfully tested on master
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks for the hard work, closing this as fixed.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: