Moodle
  1. Moodle
  2. MDL-32341

Calendar export fixed limit 60 days should be configurable

    Details

    • Testing Instructions:
      Hide
      1. upgrade moodle site
      2. goto a calendar as admin and create events as below
        1. Site event 200 days ago
        2. site event 200 days in future
        3. site event 400 days ago
        4. site event 400 days in future
        5. course event 200 days ago
        6. course event 200 days in future
        7. course event 400 days ago
        8. course event 400 days in future
      3. Goto calendar settings as admin and set the following
        1. enablecalendarexport true
        2. calendar_customexport true
        3. calendar_exportlookahead 365 days
        4. calendar_exportlookback 365 days
      4. Export calendar selecting all events and custom date range, both as url and file
      5. Make sure in each case event 2.1, 2.2, 2.5, 2.6 are included
      6. Export calendar selecting course events and custom date range, both as url and file
      7. Make sure in each case event 2.5,2.6 are included
      Show
      upgrade moodle site goto a calendar as admin and create events as below Site event 200 days ago site event 200 days in future site event 400 days ago site event 400 days in future course event 200 days ago course event 200 days in future course event 400 days ago course event 400 days in future Goto calendar settings as admin and set the following enablecalendarexport true calendar_customexport true calendar_exportlookahead 365 days calendar_exportlookback 365 days Export calendar selecting all events and custom date range, both as url and file Make sure in each case event 2.1, 2.2, 2.5, 2.6 are included Export calendar selecting course events and custom date range, both as url and file Make sure in each case event 2.5,2.6 are included
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-32341-master
    • Rank:
      39164

      Description

      The calendar export only includes the next 60 days. This date is fixed. Students wants to download all dates for the whole semester. It makes a lot of sense to make the number of days configurable by admin or user in calendar settings.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for suggesting that.

          Show
          Michael de Raadt added a comment - Thanks for suggesting that.
          Hide
          Ankit Agarwal added a comment -

          Looking at all the linked issues, I think it will be better to have a new option of custom date range export. So I have created the patch accordingly. Requesting a review.
          Thanks

          Show
          Ankit Agarwal added a comment - Looking at all the linked issues, I think it will be better to have a new option of custom date range export. So I have created the patch accordingly. Requesting a review. Thanks
          Hide
          Rossiani Wijaya added a comment -

          Hi Ankit,

          The patch looks good.

          Just some suggestion for displaying the number of days for look ahead and back.

          • instead of using the dropdown for days, it could probably be display like the 'loglifetime' option
          • or, use a textbox, instead of drop down

          Other than that, it looks great.

          [y] Syntax
          [-] Output
          [y] Whitespace
          [y] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Show
          Rossiani Wijaya added a comment - Hi Ankit, The patch looks good. Just some suggestion for displaying the number of days for look ahead and back. instead of using the dropdown for days, it could probably be display like the 'loglifetime' option or, use a textbox, instead of drop down Other than that, it looks great. [y] Syntax [-] Output [y] Whitespace [y] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
          Hide
          Ankit Agarwal added a comment -

          Made the changes as you suggested Rosie, can you have a look again?
          Thanks

          Show
          Ankit Agarwal added a comment - Made the changes as you suggested Rosie, can you have a look again? Thanks
          Hide
          Rossiani Wijaya added a comment -

          Hi Ankit,

          Thanks for making the changes.

          [y] Syntax
          [y] Output
          [y] Whitespace
          [y] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Just noting, it probably needs some documentation.

          Feel free to submit it for integration review.

          Show
          Rossiani Wijaya added a comment - Hi Ankit, Thanks for making the changes. [y] Syntax [y] Output [y] Whitespace [y] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check Just noting, it probably needs some documentation. Feel free to submit it for integration review.
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Rosie, added labels for docs and ui change.
          Submitting for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the review Rosie, added labels for docs and ui change. Submitting for integration. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Integrated thanks Ankit.

          Show
          Dan Poltawski added a comment - Integrated thanks Ankit.
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested in Master only.

          I found a couple of bugs along the way, but this change works.

          Show
          Michael de Raadt added a comment - Test result: Success! Tested in Master only. I found a couple of bugs along the way, but this change works.
          Hide
          Dan Poltawski added a comment -

          Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          Show
          Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!
          Hide
          Helen Foster added a comment -

          This nice little new feature is now documented in http://docs.moodle.org/en/Calendar_settings and mentioned in http://docs.moodle.org/en/Using_Calendar thus I'm removing the docs_required label from this issue.

          Show
          Helen Foster added a comment - This nice little new feature is now documented in http://docs.moodle.org/en/Calendar_settings and mentioned in http://docs.moodle.org/en/Using_Calendar thus I'm removing the docs_required label from this issue.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: