Moodle
  1. Moodle
  2. MDL-32342

Moodle advanced upload assignment displays notes in popup and standard window

    Details

    • Affected Branches:
      MOODLE_22_STABLE
    • Rank (Obsolete):
      39206

      Description

      In an advanced upload, when reviewing student submissions (overview of submissions), clicking on the "Notes" link displays the student's notes in a pop-up window, but the pop-up window has blocks and navigation and short page header.

      If the teacher enters the submission's detailed view (by clicking "Grade"), the "Notes" is here again but this time it doesn't open in a pop-up: it opens in the main browser window and provides a "Continue" button which brings back to the previous page. Again, this page is not a full Moodle page as it has a reduced header section.

      Our opinion is that this type of content is logically a pop-up and therefore should open in a pop-up window, and that this window should not contain any blocks or navigation.

      Replication steps:

      1. Create an Advanced upload assignment
      2. In the settings of the assignment, allow Notes
      3. Log in as a student and submit a file and add notes
      4. Log in as a teacher and view the submission in the submissions table
      5. Click on the link for notes and view the pop-up used
      6. Close this window
      7. Click on the link for grades
      8. Click on the link for notes on the grading page
      9. Note that this reloads the page

        Activity

        Nicolas Dunand created issue -
        Hide
        Nicolas Dunand added a comment -

        Proposed patch to make notes.php behave like a pop-up in both cases, and to make the page use a pop-up layout.

        Show
        Nicolas Dunand added a comment - Proposed patch to make notes.php behave like a pop-up in both cases, and to make the page use a pop-up layout.
        Nicolas Dunand made changes -
        Field Original Value New Value
        Attachment proposed MDL-32342.diff [ 27848 ]
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this and supplying a patch.

        I've added some replication steps to your description. Feel free to adjust them.

        It would be good if the display of notes was consistent, however, for the sake of accessibility, it would be good if we could avoid pop-ups.

        Show
        Michael de Raadt added a comment - Thanks for reporting this and supplying a patch. I've added some replication steps to your description. Feel free to adjust them. It would be good if the display of notes was consistent, however, for the sake of accessibility, it would be good if we could avoid pop-ups.
        Michael de Raadt made changes -
        Summary Moodle advanced upload assignment displays notes in popup and stanrdard window the same way Moodle advanced upload assignment displays notes in popup and standard window
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Fix Version/s STABLE backlog [ 10463 ]
        Description In an advanced upload, when reviewing student submissions (overview of submissions), clicking on the "Notes" link displays the student's notes in a pop-up window, but the pop-up window has blocks and navigation and short page header.

        If the teacher enters the submission's detailed view (by clicking "Grade"), the "Notes" is here again but this time it doesn't open in a pop-up: it opens in the main browser window and provides a "Continue" button which brings back to the previous page. Again, this page is not a full Moodle page as it has a reduced header section.

        Our opinion is that this type of content is logically a pop-up and therefore should open in a pop-up window, and that this window should not contain any blocks or navigation.
        In an advanced upload, when reviewing student submissions (overview of submissions), clicking on the "Notes" link displays the student's notes in a pop-up window, but the pop-up window has blocks and navigation and short page header.

        If the teacher enters the submission's detailed view (by clicking "Grade"), the "Notes" is here again but this time it doesn't open in a pop-up: it opens in the main browser window and provides a "Continue" button which brings back to the previous page. Again, this page is not a full Moodle page as it has a reduced header section.

        Our opinion is that this type of content is logically a pop-up and therefore should open in a pop-up window, and that this window should not contain any blocks or navigation.

        *Replication steps:*
        # Create an Advanced upload assignment
        # In the settings of the assignment, allow Notes
        # Log in as a student and submit a file and add notes
        # Log in as a teacher and view the submission in the submissions table
        # Click on the link for notes and view the pop-up used
        # Close this window
        # Click on the link for grades
        # Click on the link for notes on the grading page
        # Note that this reloads the page
        Labels patch triaged
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Nicolas Dunand added a comment -

        Thanks Michael. We're not using the old mod_assignment anymore, so I'm not going to bother with this – especially since Votes/Watching seems to indicate this is not a problem to anyone else

        Show
        Nicolas Dunand added a comment - Thanks Michael. We're not using the old mod_assignment anymore, so I'm not going to bother with this – especially since Votes/Watching seems to indicate this is not a problem to anyone else

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: