Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.2
-
Fix Version/s: 2.2.3
-
Component/s: Installation
-
Labels:None
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-32349-master -
Pull Master Diff URL:
-
Rank:39172
Description
sam found this.
Activity
+1 from me. (I do wonder a bit if we should have an if (!CLI... since CLI scripts never time out, but still.)
+1 for 60*10
Changed to 600 as requested (I see why, this is now consistent with another set_time_limit in upgradelib).
The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
Thanks Sam, this has been integrated now.
A fresh installation was done. Nothing broke. Checked to make sure that the code was integrated. No problems.
Thanks.
Jolly good show!
Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.
Tally-ho!
Submitting for integration as this is a trivial fix.
Note: I verified that this fixed my installation problem (which occurred on Moodle 2.2.2 with approx 130 additional plugins, but might I suppose also occur for a core system if it had a very slow database).