Moodle
  1. Moodle
  2. MDL-32349

Installing through the web brower can time-out if you have a lot of plugins

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: Installation
    • Labels:
      None

      Description

      sam found this.

        Gliffy Diagrams

          Activity

          Hide
          Sam Marshall added a comment -

          Submitting for integration as this is a trivial fix.

          Note: I verified that this fixed my installation problem (which occurred on Moodle 2.2.2 with approx 130 additional plugins, but might I suppose also occur for a core system if it had a very slow database).

          Show
          Sam Marshall added a comment - Submitting for integration as this is a trivial fix. Note: I verified that this fixed my installation problem (which occurred on Moodle 2.2.2 with approx 130 additional plugins, but might I suppose also occur for a core system if it had a very slow database).
          Hide
          Tim Hunt added a comment -

          +1 from me. (I do wonder a bit if we should have an if (!CLI... since CLI scripts never time out, but still.)

          Show
          Tim Hunt added a comment - +1 from me. (I do wonder a bit if we should have an if (!CLI... since CLI scripts never time out, but still.)
          Hide
          Petr Skoda added a comment -

          +1 for 60*10

          Show
          Petr Skoda added a comment - +1 for 60*10
          Hide
          Sam Marshall added a comment -

          Changed to 600 as requested (I see why, this is now consistent with another set_time_limit in upgradelib).

          Show
          Sam Marshall added a comment - Changed to 600 as requested (I see why, this is now consistent with another set_time_limit in upgradelib).
          Hide
          Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Aparup Banerjee added a comment - The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Sam, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Sam, this has been integrated now.
          Hide
          Adrian Greeve added a comment -

          A fresh installation was done. Nothing broke. Checked to make sure that the code was integrated. No problems.
          Thanks.

          Show
          Adrian Greeve added a comment - A fresh installation was done. Nothing broke. Checked to make sure that the code was integrated. No problems. Thanks.
          Hide
          Dan Poltawski added a comment -

          Jolly good show!

          Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

          Tally-ho!

          Show
          Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: