Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32349

Installing through the web brower can time-out if you have a lot of plugins

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: Installation
    • Labels:
      None

      Description

      sam found this.

        Gliffy Diagrams

          Attachments

            Activity

            timhunt Tim Hunt created issue -
            timhunt Tim Hunt made changes -
            Field Original Value New Value
            Assignee moodle.com [ moodle.com ] Sam Marshall [ quen ]
            quen Sam Marshall made changes -
            Pull Master Diff URL https://github.com/sammarshallou/moodle/compare/master...MDL-32349-master
            Pull Master Branch MDL-32349-master
            Testing Instructions 1. Install a fresh copy of Moodle.

            - Check it still installs
            Pull from Repository git://github.com/sammarshallou/moodle.git
            Hide
            quen Sam Marshall added a comment -

            Submitting for integration as this is a trivial fix.

            Note: I verified that this fixed my installation problem (which occurred on Moodle 2.2.2 with approx 130 additional plugins, but might I suppose also occur for a core system if it had a very slow database).

            Show
            quen Sam Marshall added a comment - Submitting for integration as this is a trivial fix. Note: I verified that this fixed my installation problem (which occurred on Moodle 2.2.2 with approx 130 additional plugins, but might I suppose also occur for a core system if it had a very slow database).
            quen Sam Marshall made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            Hide
            timhunt Tim Hunt added a comment -

            +1 from me. (I do wonder a bit if we should have an if (!CLI... since CLI scripts never time out, but still.)

            Show
            timhunt Tim Hunt added a comment - +1 from me. (I do wonder a bit if we should have an if (!CLI... since CLI scripts never time out, but still.)
            Hide
            skodak Petr Skoda added a comment -

            +1 for 60*10

            Show
            skodak Petr Skoda added a comment - +1 for 60*10
            Hide
            quen Sam Marshall added a comment -

            Changed to 600 as requested (I see why, this is now consistent with another set_time_limit in upgradelib).

            Show
            quen Sam Marshall added a comment - Changed to 600 as requested (I see why, this is now consistent with another set_time_limit in upgradelib).
            Hide
            nebgor Aparup Banerjee added a comment -

            The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            nebgor Aparup Banerjee added a comment - The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Sam, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Sam, this has been integrated now.
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.2.3 [ 12053 ]
            abgreeve Adrian Greeve made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester abgreeve
            Hide
            abgreeve Adrian Greeve added a comment -

            A fresh installation was done. Nothing broke. Checked to make sure that the code was integrated. No problems.
            Thanks.

            Show
            abgreeve Adrian Greeve added a comment - A fresh installation was done. Nothing broke. Checked to make sure that the code was integrated. No problems. Thanks.
            abgreeve Adrian Greeve made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            poltawski Dan Poltawski added a comment -

            Jolly good show!

            Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

            Tally-ho!

            Show
            poltawski Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!
            poltawski Dan Poltawski made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 12/Apr/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12