Moodle
  1. Moodle
  2. MDL-32355

Redundant style selectors in formal_white

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      This issue fixes a parent ordering issue and removes unneeded CSS.
      To test this you just need to test that the format white theme still works.
      Please log in, change your theme to formal_white and have a good play with it.

      Show
      This issue fixes a parent ordering issue and removes unneeded CSS. To test this you just need to test that the format white theme still works. Please log in, change your theme to formal_white and have a good play with it.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32355_master
    • Rank:
      39178

      Description

      Some style selectors are useless in formal_white. They could be inherited from canvas/styles/core.css
      Core.css from canvas theme should be included in order to improve the reliability e maintainability of the theme.

        Activity

        Daniele Cordella created issue -
        Daniele Cordella made changes -
        Field Original Value New Value
        Assignee Patrick Malley [ ptrkmkl ] Daniele Cordella [ daniss ]
        Daniele Cordella made changes -
        Status Open [ 1 ] Waiting for peer review [ 10012 ]
        Pull Master Diff URL https://github.com/kordan/moodle/compare/master...MDL-32355_master
        Pull Master Branch MDL-32355_master
        Pull from Repository git://github.com/kordan/moodle.git
        Dan Poltawski made changes -
        Peer reviewer lazydaisy
        Daniele Cordella made changes -
        Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
        Daniele Cordella made changes -
        Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
        Sam Hemelryk made changes -
        Currently in integration Yes [ 10041 ]
        Sam Hemelryk made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Integrator samhemelryk
        Sam Hemelryk made changes -
        Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
        Fix Version/s 2.3 [ 10657 ]
        Sam Hemelryk made changes -
        Testing Instructions This issue fixes a parent ordering issue and removes unneeded CSS.
        To test this you just need to test that the format white theme still works.
        Please log in, change your theme to formal_white and have a good play with it.
        Michael de Raadt made changes -
        Labels triaged
        Michael de Raadt made changes -
        Tester andyjdavis
        Andrew Davis made changes -
        Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
        Andrew Davis made changes -
        Status Testing in progress [ 10011 ] Tested [ 10006 ]
        Dan Poltawski made changes -
        Status Tested [ 10006 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Currently in integration Yes [ 10041 ]
        Dan Poltawski made changes -
        Integration date 19/Apr/12

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: