Moodle
  1. Moodle
  2. MDL-32357

Unread post tracking does not work for blog-style forums

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      1) Use standard theme
      2) Create a course in social format. As user A, post a bunch of posts there as new discussions and replies to form some nice threads.
      3) As user B, visit the course, you should see the discussion starters.
      4) Now go to one of the discussion threads to read the replies. The replies should be highlighted as "Unread" in orange.
      5) Refresh this page. None of the posts should be orange, as they've been marked read.

      Repeat for site news on the home page.

      Show
      1) Use standard theme 2) Create a course in social format. As user A, post a bunch of posts there as new discussions and replies to form some nice threads. 3) As user B, visit the course, you should see the discussion starters. 4) Now go to one of the discussion threads to read the replies. The replies should be highlighted as "Unread" in orange. 5) Refresh this page. None of the posts should be orange, as they've been marked read. Repeat for site news on the home page.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      39183

      Description

      This has been annoying me on moodle.org, with the Integration exposed forum. It always shows that there are unread posts, even if you have read them.

        Activity

        Hide
        Tim Hunt added a comment -

        Please can someone who understand forums review this carefully.

        As far as I can see, my change only affects these three cases:
        1. Blog-style forums - the case we want to fix,
        2. Site news forum, and
        3. Social course format.

        (Search for where forum_print_latest_discussions is only called with mode 'plain').

        In all cases, having read tracking work properly seems like the right thing to do.

        Also, it would be good if someone who really understands this stuff could write the testing instructions. Thanks.

        Show
        Tim Hunt added a comment - Please can someone who understand forums review this carefully. As far as I can see, my change only affects these three cases: 1. Blog-style forums - the case we want to fix, 2. Site news forum, and 3. Social course format. (Search for where forum_print_latest_discussions is only called with mode 'plain'). In all cases, having read tracking work properly seems like the right thing to do. Also, it would be good if someone who really understands this stuff could write the testing instructions. Thanks.
        Hide
        Dan Poltawski added a comment -

        So I think the best person to fit your criteria would be MD?

        Show
        Dan Poltawski added a comment - So I think the best person to fit your criteria would be MD?
        Hide
        Martin Dougiamas added a comment - - edited

        The change looks fine for me. Testers just need to test that unread posts still works normally in other cases where "latest" discussions are printed. Such as the news on the front page. +2 to integrate

        Show
        Martin Dougiamas added a comment - - edited The change looks fine for me. Testers just need to test that unread posts still works normally in other cases where "latest" discussions are printed. Such as the news on the front page. +2 to integrate
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Tim Hunt added a comment -

        To INTEGRATORS,

        Not sure how many branches we want to cherry pick this to. I will leave that to your discretion.

        Show
        Tim Hunt added a comment - To INTEGRATORS, Not sure how many branches we want to cherry pick this to. I will leave that to your discretion.
        Hide
        Dan Poltawski added a comment - - edited

        Thanks Tim i've integrated this. I've back-ported it to 22 and 21

        Show
        Dan Poltawski added a comment - - edited Thanks Tim i've integrated this. I've back-ported it to 22 and 21
        Hide
        Ankit Agarwal added a comment -

        This is working as expected in 21 22 and master.
        Thanks

        Show
        Ankit Agarwal added a comment - This is working as expected in 21 22 and master. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -
        UPDATE tracker_issues
           SET status = 'Closed',
              comment = 'Thanks!'
        WHEN participants = 'Did a gorgeous work'
        

        This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

        Show
        Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: