Moodle
  1. Moodle
  2. MDL-32359

Forums: it is to easy to click 'mark all read' when jumping to the first unread post in a discussion

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Forum, Usability
    • Labels:
    • Testing Instructions:
      Hide

      1. You need a course with two users A and B,
      2. and a forum where B has unread post tracking turned on (this may require you to enable the feature at site level as admin first).
      3. As user A, make a post in the forum, or a new discussion.
      4. As user B, go to the list of discussions.
      5. Verify that there is a small but significant gap between the number of unread posts, and the 'mark thread read' tick.
      6. Verify that if you click in the ambiguous space between the two, it activates the link to the first unread post, and does not mark the thread as read.

      Show
      1. You need a course with two users A and B, 2. and a forum where B has unread post tracking turned on (this may require you to enable the feature at site level as admin first). 3. As user A, make a post in the forum, or a new discussion. 4. As user B, go to the list of discussions. 5. Verify that there is a small but significant gap between the number of unread posts, and the 'mark thread read' tick. 6. Verify that if you click in the ambiguous space between the two, it activates the link to the first unread post, and does not mark the thread as read.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      39185

      Description

      You need a forum with read-tracking turned on.

      On the front page of a forum, where it lists all the discussions, there is a column 'Unread'. In this column you get the unread message count that comprises two bits:

      1. A count of the unread messages. If you click this, you get taken to the first unread message in the thread.

      2. A tick icon. If you click this, all the messages get marked a read.

      It is too easy to click 2. when you mean to click 1. (This is my personal observation from reading the moodle.org forums.)

        Activity

        Hide
        Dan Poltawski added a comment -

        This has annoyed me too, looks OK to me

        Show
        Dan Poltawski added a comment - This has annoyed me too, looks OK to me
        Hide
        Tim Hunt added a comment -

        Thanks Dan. I'll take that as in OK to submit for integration review now.

        To INTEGRATORS: Note, I am submitting for 2.3 only, In case there is some themer out there who thinks their theme is just perfect right now, and who would hate the extra space. They are more likely to review their theme in a major upgrade (2.2 -> 2.3) than when updating to the latest weekly. If, however, you disagree with this reasoning, you may wish to back-port.

        Show
        Tim Hunt added a comment - Thanks Dan. I'll take that as in OK to submit for integration review now. To INTEGRATORS: Note, I am submitting for 2.3 only, In case there is some themer out there who thinks their theme is just perfect right now, and who would hate the extra space. They are more likely to review their theme in a major upgrade (2.2 -> 2.3) than when updating to the latest weekly. If, however, you disagree with this reasoning, you may wish to back-port.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Michael de Raadt added a comment -

        Test result: Success.

        No worries.

        Show
        Michael de Raadt added a comment - Test result: Success. No worries.
        Hide
        Dan Poltawski added a comment -

        Bonza mate!

        Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.

        Hooroo

        Show
        Dan Poltawski added a comment - Bonza mate! Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby. Hooroo

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: