Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31167 PHP strict META
  3. MDL-32381

Accessing non-static methods in repository class as static (PHP meta STRICT)

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      1. enable strict mode in php.ini
      2. force strict mode in main config.php

      3. Using FilePicker try to add the file with the same name as already existing. The popup dialog should appear with choice s: Rename, Overwrite, Cancel.
      Make sure all buttons work as expected.

      Show
      1. enable strict mode in php.ini 2. force strict mode in main config.php 3. Using FilePicker try to add the file with the same name as already existing. The popup dialog should appear with choice s: Rename, Overwrite, Cancel. Make sure all buttons work as expected.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-32381-master

      Description

      I found number of PHP notices when using STRICT:

      Strict Standards: Non-static method repository::overwrite_existing_draftfile() should not be called statically in /var/www/repositories/master/moodle/repository/repository_ajax.php on line 278
      true

      the same for function append_suffix($filename) and delete_tempfile_from_draft($draftitemid, $filepath, $filename)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Integrator:
              Dan Poltawski
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12