Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.2
-
Component/s: Themes
-
Testing Instructions:
-
Workaround:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-32385_master -
Pull Master Diff URL:
Description
When creating/editing a Summary if the first line of text has a "Font size" that is set to any value above 5 (18pt) and the "Format" is set to anything but a "Heading" then the top of the text is cut off. I have tested all the themes while viewing a fresh installation of Moodle 2.2.2 and have found the issue in three themes. The browser I am using is Firefox.
Replicable when using the following themes:
Anomaly
Formal White
Standard
Testing:
1] From the Front Page or within a course turn editing on
2] With editing on click "Edit summary" icon
3] Use any Font type, use a Font size larger than 5 (18pt), and use any format but the "Headings"
4] Type a line of text
5] Save changes
6] In the above mentioned themes the top of the text will be cut off.
The screen shots taken have the following settings for the text set:
Font type: Arial
Font Size: 7 (36pt)
Format: Paragraph
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
I was analysing the elements styles. And I reached the following conclusion.
I have also uploaded a screenshot that shows why the top of the text is chopped off.
There is a default font-size and line-height for the summary, in the theme files (as it uses style .path-course-view .section).
But, when we use a custom font size in the summary editor, the font-size is overridden (by a span), but the line-height remains as inherited.
Further, the themes which do not set the summary style to .path-course-view .section, show the summary correctly.
I couldn't notice this issue with the Anomaly theme.
Although the line-height is inherited, it is large enough to fit 7pt text.
And Standard and Formal White are indeed the only 2 themes with this issue.
I have added 1 new rule per theme to resolve this issue :
Standard
.path-course-view .section .summary {font-size:0.95em;line-height:normal;}
|
Formal White
.path-course-view .section .summary{line-height:normal;}
|
This overrides the 1.2em line-height to normal line-height.
Pull master Diff : https://github.com/SaswatPadhi/moodle/compare/master...MDL-32385
Pull MDL22 Diff : https://github.com/SaswatPadhi/moodle/compare/MOODLE_22_STABLE...MDL-32385_22
Thank you for the update! I will inform our devs to have or local repositories updated. Thank you again for all your hard work!!
Sincerely,
Joe
@Michael
Can you please explain the significance of the 'Partner' label this issues has attached to it? Do I treat this in the normal way fixing master and Moodle stable branches?
Please advise?
I have added the patch to BASE theme. This way it will fix Anomaly, Formal White and Standard, as all themes inherit styles from Base theme.
Cheers
Mary
Thanks Mary - this has been integrated now.
looks good to me 
Bonza mate!
Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.
Hooroo
I second what Dan said!!
Thank you for all your help Saswat & Mary!!
Re-added screen captures to show the error without editing turned on.