Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32392

Consider deleting protected and unused is_min_version() in some DB drivers

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Database SQL/XMLDB
    • Labels:

      Description

      While working on MDL-32368 for postgres, it was detected that some drivers have the is_min_version() method, defined as protected, and never used at all along codebase.

      grep -r is_min_version *
      
      lib/dml/mssql_native_moodle_database.php:    protected function is_min_version($version) {
      lib/dml/oci_native_moodle_database.php:    protected function is_min_version($version) {
      lib/dml/pgsql_native_moodle_database.php:    protected function is_min_version($version) {
      lib/dml/sqlsrv_native_moodle_database.php:    protected function is_min_version($version) {
      

      So this is about to:

      1) delete the method from all drivers.
      2) change it to private in the pgsql one, as far as MDL-32368 is using it.

      Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12