Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Unit tests
    • Labels:
    • Rank:
      39259

      Description

      Done:

      • completionlib
      • new exit code constants
      • improved diagnostic message for missing DbUnit extension
      • remove @ silencing from diagnostic includes
      • fixed paths in windows phpunit configuration files
      • improved module generators - triggering gradebook and events changes now

      todo:

      • hide simpletest UI
      • delete all converted simpletests
      • webservices - it must be completely redesigned to not rely on HTTP

      notes:

      • I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs

        Issue Links

          Activity

          Petr Škoda created issue -
          Petr Škoda made changes -
          Field Original Value New Value
          Link This issue has been marked as being related by MDL-32323 [ MDL-32323 ]
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          Petr Škoda made changes -
          Fix Version/s DEV backlog [ 10464 ]
          Priority Minor [ 4 ] Critical [ 2 ]
          Labels triaged
          Assignee Eloy Lafuente (stronk7) [ stronk7 ] Petr Škoda (skodak) [ skodak ]
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat
          Petr Škoda made changes -
          Link This issue has a non-specific relationship to MDL-30210 [ MDL-30210 ]
          Andrew Nicols made changes -
          Link This issue will be resolved by MDL-32426 [ MDL-32426 ]
          Petr Škoda made changes -
          Description todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * completionlib - using mocks heavily
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat
          Done:
          * completionlib


          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat
          Petr Škoda made changes -
          Description Done:
          * completionlib


          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * do not complain about dirroot permissions from webrunner
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * rework if (PHPUNIT_TEST and !PHPUNIT_UTIL) { in lib/setup.php - the problem is we need to reset even in PHPUNIT_UTIL and skip only in diag
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat
          Done:
          * completionlib


          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat
          Petr Škoda made changes -
          Description Done:
          * completionlib


          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat
          Done:
          * completionlib


          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat

          notes:
          * I have decided to not use PHP constants for exit return codes because the codes are used in batch scripts and the constants were actually making it more confusing
          Petr Škoda made changes -
          Description Done:
          * completionlib


          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * show better error message when database support missing
          * remove the @include in util.php
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat

          notes:
          * I have decided to not use PHP constants for exit return codes because the codes are used in batch scripts and the constants were actually making it more confusing
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * use constants in error handling
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Link This issue is blocked by MDL-32434 [ MDL-32434 ]
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * verify dataroot is not shared with production server
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function
          * verify buildconfig works in init.bat

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * in database reset report extra tables to be dropped + deal with temp tables somehow
          * in runBare() ignore reset problems when text failed so that we do not loose the original $e
          * fix paths in windows phpunit.xml generation function

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * fix paths in windows phpunit.xml generation function

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI
          * fix paths in windows phpunit.xml generation function

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - seems to do nothing
          * delete all converted simpletests
          * hide simpletest UI

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - it must be completely redesigned to not rely on HTTP
          * delete all converted simpletests
          * hide simpletest UI

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files

          todo:
          * discuss problem in navigationlib_test.php method test_find_expandable() with SamH
          * webservices - it must be completely redesigned to not rely on HTTP
          * delete all converted simpletests
          * hide simpletest UI

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files

          todo:
          * hide simpletest UI
          * delete all converted simpletests
          * webservices - it must be completely redesigned to not rely on HTTP

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w16_MDL-32400_m23_phpunit4
          Pull Master Branch w16_MDL-32400_m23_phpunit4
          Pull from Repository git://github.com/skodak/moodle.git
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s DEV backlog [ 10464 ]
          Testing Instructions run phpunit tests in all supported dbs
          Petr Škoda made changes -
          Link This issue blocks MDL-32437 [ MDL-32437 ]
          Petr Škoda made changes -
          Description Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files

          todo:
          * hide simpletest UI
          * delete all converted simpletests
          * webservices - it must be completely redesigned to not rely on HTTP

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Done:
          * completionlib
          * new exit code constants
          * improved diagnostic message for missing DbUnit extension
          * remove @ silencing from diagnostic includes
          * fixed paths in windows phpunit configuration files
          * improved module generators - triggering gradebook and events changes now

          todo:
          * hide simpletest UI
          * delete all converted simpletests
          * webservices - it must be completely redesigned to not rely on HTTP

          notes:
          * I have decided to remove the init.sh and init.bat and keep only init.php, this should simplify maintenance and prevent bugs
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Dan Poltawski made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator poltawski
          Dan Poltawski made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Michael de Raadt made changes -
          Tester rajeshtaneja
          Rajesh Taneja made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Rajesh Taneja made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Dan Poltawski made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Dan Poltawski made changes -
          Integration date 19/Apr/12
          Petr Škoda made changes -
          Link This issue blocks MDL-32569 [ MDL-32569 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-21015 [ MDL-21015 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-17644 [ MDL-17644 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-19137 [ MDL-19137 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-28122 [ MDL-28122 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: