Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      For developers - look for E_STRICT warnings:
      1/ try all custom profile field types - create, edit, view
      2/ break definition of some form - invalid element type, wrong element name in other form methods

      Show
      For developers - look for E_STRICT warnings: 1/ try all custom profile field types - create, edit, view 2/ break definition of some form - invalid element type, wrong element name in other form methods
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w16_MDL-32405_m23_estrict4

      Description

      add stacktraces for problematic places here

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andrew Davis added a comment - - edited

            While creating a new group.

            Strict Standards: Non-static method PEAR::raiseError() should not be called statically, assuming $this from incompatible context in /home/andrew/Desktop/code/moodle/int/master/lib/pear/HTML/QuickForm.php on line 748 Strict Standards: Non-static method HTML_QuickForm::errorMessage() should not be called statically, assuming $this from incompatible context in /home/andrew/Desktop/code/moodle/int/master/lib/pear/HTML/QuickForm.php on line 1988 Strict Standards: Non-static method HTML_QuickForm::isError() should not be called statically, assuming $this from incompatible context in /home/andrew/Desktop/code/moodle/int/master/lib/pear/HTML/QuickForm.php on line 1952 QuickForm Error: nonexistent html element Element 'imagefile' does not exist in HTML_QuickForm::getElement()
            Backtrace : removed by skodak

            Skip to main content
            This page should automatically redirect. If nothing is happening please use the continue link below.
            (Continue)

            Error output, so disabling automatic redirect.

            Show
            Andrew Davis added a comment - - edited While creating a new group. Strict Standards: Non-static method PEAR::raiseError() should not be called statically, assuming $this from incompatible context in /home/andrew/Desktop/code/moodle/int/master/lib/pear/HTML/QuickForm.php on line 748 Strict Standards: Non-static method HTML_QuickForm::errorMessage() should not be called statically, assuming $this from incompatible context in /home/andrew/Desktop/code/moodle/int/master/lib/pear/HTML/QuickForm.php on line 1988 Strict Standards: Non-static method HTML_QuickForm::isError() should not be called statically, assuming $this from incompatible context in /home/andrew/Desktop/code/moodle/int/master/lib/pear/HTML/QuickForm.php on line 1952 QuickForm Error: nonexistent html element Element 'imagefile' does not exist in HTML_QuickForm::getElement() Backtrace : removed by skodak Skip to main content This page should automatically redirect. If nothing is happening please use the continue link below. (Continue) Error output, so disabling automatic redirect.
            Hide
            Petr Skoda added a comment - - edited

            custom fields from MDL-32435 and MDL-32383

            Show
            Petr Skoda added a comment - - edited custom fields from MDL-32435 and MDL-32383
            Hide
            Sam Hemelryk added a comment -

            Thanks Petr, these changes have been implemented now

            All making it yet harder to upgrade and more reason to look for a replacement

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Thanks Petr, these changes have been implemented now All making it yet harder to upgrade and more reason to look for a replacement Cheers Sam
            Hide
            Michael de Raadt added a comment -

            Test result: Success.

            I created and tested each custom profile type. They all seem to work without errors now. I completed a import on the menu field as well as this was a source of problems in the past.

            I was presented with what I assume as the expected form exception when I used an incorrect element name. It was quite extensive. I didn't see any error when using an incorrect name with setDefault() and setType() - I assume that was the expected behaviour. I saw a Moodle error when I used the incorrect name with addHelpButton().

            Show
            Michael de Raadt added a comment - Test result: Success. I created and tested each custom profile type. They all seem to work without errors now. I completed a import on the menu field as well as this was a source of problems in the past. I was presented with what I assume as the expected form exception when I used an incorrect element name. It was quite extensive. I didn't see any error when using an incorrect name with setDefault() and setType() - I assume that was the expected behaviour. I saw a Moodle error when I used the incorrect name with addHelpButton().
            Hide
            Dan Poltawski added a comment -

            Bonza mate!

            Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.

            Hooroo

            Show
            Dan Poltawski added a comment - Bonza mate! Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby. Hooroo

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: