Moodle
  1. Moodle
  2. MDL-32412

Convert Afterburner theme to use percentage layout in Moodle 2.3

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test requires you have Hebrew (RTL) or another RTL lang pack installed.

      1. First ensure that 'Languages' are enabled in Moodle 2.3 prior to testing.
      2. Select Afterburner via Theme selector in usual way (NOT by URL)
      3. Test in all areas of Moodle using LTR language (English)
      4. Select Hebrew or another RTL language and test all areas of Moodle for consistency of design and usability
      Show
      Test requires you have Hebrew (RTL) or another RTL lang pack installed. First ensure that 'Languages' are enabled in Moodle 2.3 prior to testing. Select Afterburner via Theme selector in usual way (NOT by URL) Test in all areas of Moodle using LTR language (English) Select Hebrew or another RTL language and test all areas of Moodle for consistency of design and usability
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip_MDL-32412_afterburner
    • Rank:
      39271

      Description

      Based on the work done to create BASE-RTL, a theme that works well in RTL as well as LTR,
      it is proposed to convert the page layout in Afterburner to use Matthew James Taylor's Perfect Holy Grail layout, a percentage layout designed to work in all browsers including IE7. To overcome Internet Explorer's broken box model, no horizontal padding or margins are used in conjunction with a width. Instead, this design uses percentage widths and clever relative positioning.

      All the dimensions are in percentage widths so the layout adjusts to any screen resolution. Vertical dimensions are not set so they stretch to the height of the content.

      Maximum column content widths: To prevent wide content (like long URLs) from destroying the layout (long content can make the page scroll horizontally) the column content divs are set to overflow:hidden. This chops off any content that is wider than the div.

      Because of this, it's important to know the maximum widths allowable at common screen resolutions. For example, if you choose 800 x 600 pixels as your minimum compatible resolution what is the widest image that can be safely added to each column before it gets chopped off? Here are the figures:

      800 x 600
      Left & right columns: 162 pixels
      Center page: 357 pixels
      1024 x 768
      Left & right columns: 210 pixels
      Center page: 459 pixels

      RTL Support: This layout was chosen especially for its ability to work in Moodle when RTL languages are selected. The proposed changes require few modifications from the previous layout structure, which was Matthew James Taylor's No-Quirks Mode, but it will also include the changes proposed by Nadav Kavalerchik in MDL-32481 which include additional CSS for the custommenu when in RTL mode and also the ability for the theme to 'swap' side column contents, a much needed requirement requested by the RTL communities around the world.

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          This has been Peer Reviewed by Nadav in MDL-26400

          Show
          Mary Evans added a comment - This has been Peer Reviewed by Nadav in MDL-26400
          Hide
          Mary Evans added a comment -

          @Nadav

          I've just added you as a watcher to keep you in the loop.
          Thanks for all your help with this theme.
          Let's hope it pays off!

          Mary

          Show
          Mary Evans added a comment - @Nadav I've just added you as a watcher to keep you in the loop. Thanks for all your help with this theme. Let's hope it pays off! Mary
          Hide
          Mary Evans added a comment -

          I'm just testing this now in Moodle 2.3 Alpha and found a few things not working in the theme as they should. If it's not too late, I'll try and get these fixed tomorrow.

          1. RTL Dock not coded correctly = missing .dir-rtl also a missing margin for when body.hasdock in RTL so dock covers 30px of right side of page.

          2. Page should be 100% width, but a setting in core.css is over-riding pagelayout.css.

          Show
          Mary Evans added a comment - I'm just testing this now in Moodle 2.3 Alpha and found a few things not working in the theme as they should. If it's not too late, I'll try and get these fixed tomorrow. 1. RTL Dock not coded correctly = missing .dir-rtl also a missing margin for when body.hasdock in RTL so dock covers 30px of right side of page. 2. Page should be 100% width, but a setting in core.css is over-riding pagelayout.css.
          Hide
          Nadav Kavalerchik added a comment -

          Is it already in 2.3dev (master)? If i pull it will i get your version?

          Show
          Nadav Kavalerchik added a comment - Is it already in 2.3dev (master)? If i pull it will i get your version?
          Hide
          Mary Evans added a comment -

          Hi Nadav,

          No it's not in Master yet. This is only first stage.

          In GIT you can get my copy using the following GIT command...

          git fetch git://github.com/lazydaisy/moodle.git MDL-32412_master

          this will download all required data and will keep the pointer to the tip of the branch in a local reference FETCH_HEAD. You can then create a new branch on your Local repository with this GIT command...

          git checkout -b MARYS_MDL-32412_master FETCH_HEAD

          At least this is how I would do it! But then I am still learning GIT.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Nadav, No it's not in Master yet. This is only first stage. In GIT you can get my copy using the following GIT command... git fetch git://github.com/lazydaisy/moodle.git MDL-32412 _master this will download all required data and will keep the pointer to the tip of the branch in a local reference FETCH_HEAD. You can then create a new branch on your Local repository with this GIT command... git checkout -b MARYS_ MDL-32412 _master FETCH_HEAD At least this is how I would do it! But then I am still learning GIT. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Hi Mary,

          Ok, I already have your github/lazydaisy cloned on my local develop machine
          Just thought you pushed a more updated version to moodle.git/master
          I will have time to check it out on the weekend

          Show
          Nadav Kavalerchik added a comment - Hi Mary, Ok, I already have your github/lazydaisy cloned on my local develop machine Just thought you pushed a more updated version to moodle.git/master I will have time to check it out on the weekend
          Hide
          Mary Evans added a comment - - edited

          I have just updated this branch to fix the dock CSS and page width in pagelayout and core. I coded it so only #page width is set in pagelayout.css and #page fonts and color.
          in core.css, so you might like to look at my last commit here to check you have the same.
          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited I have just updated this branch to fix the dock CSS and page width in pagelayout and core. I coded it so only #page width is set in pagelayout.css and #page fonts and color. in core.css, so you might like to look at my last commit here to check you have the same. Cheers Mary
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Hi,

          could you explain a bit which is the plan for correct handling RTL langs in core themes and how this new theme is related with that plan? Or is it completely unrelated?

          My initial POV about this is that is sort of "workaround" to current RTL problems/limitations in core themes, but perhaps I'm wrong and there is a "master plan" out there, hence I'm asking about it.

          Because, or I'm wrong and it has been decided somewhere or the primary goal should be to fix any RTL problem in core (base, canvas, xxx) themes, isn't it?

          Also, I'm linking to this issue @ HQ chat for broader audience.

          Thanks for the hard work, I'm keeping this halted until directions are clear. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Hi, could you explain a bit which is the plan for correct handling RTL langs in core themes and how this new theme is related with that plan? Or is it completely unrelated? My initial POV about this is that is sort of "workaround" to current RTL problems/limitations in core themes, but perhaps I'm wrong and there is a "master plan" out there, hence I'm asking about it. Because, or I'm wrong and it has been decided somewhere or the primary goal should be to fix any RTL problem in core (base, canvas, xxx) themes, isn't it? Also, I'm linking to this issue @ HQ chat for broader audience. Thanks for the hard work, I'm keeping this halted until directions are clear. Ciao
          Hide
          Mary Evans added a comment - - edited

          Eloy,

          I dont think there are any hard or fast rules regarding the right or wrong way of handeling RTL CSS in Moodle. At the moment these .dir-rtl CSS rules are scattered over a wide area mainly in every CSS file in Base theme and some in other CORE themes where the layouts differ from the norm, like Canvas, Afterburner and Magazine.

          Base-RTL on the other hand, also has a fair amount of .dir-rtl CSS styles, but these are placed in one rtl.css file with the exception of the menu-rtl.css which was easier to manage while working on this theme, but these could easily go into the rtl.css. This makes updating much easier.

          BASE-RTL theme is different insofar as it works in IE7 when logging in where current Moodle theme's don't. I know too that @HQ a decision was made to not continue with support for older browsers including IE7 & IE8, that said, it would be a pity to throw away this opportunity to prove to the RTL Moodle Community that Moodle is willing to go that extra mile to support Base-RTL that can become a parent theme for other themes to build upon, especially those who want RTL themes that will no only work in IE7 & IE8, but also be capable of swapping left and right columns when RTL is enabled, and also move the dock and the custommenu from left to right.

          Base-RTL is based on the Holy Grail Percentage Layout, and as such is, in my opinion the theme that should have been adopted in the first place. And also, if I may make so bold a statement, it is one that should be addopted as THE parent theme for future development in Moodle 2.4.

          Show
          Mary Evans added a comment - - edited Eloy, I dont think there are any hard or fast rules regarding the right or wrong way of handeling RTL CSS in Moodle. At the moment these .dir-rtl CSS rules are scattered over a wide area mainly in every CSS file in Base theme and some in other CORE themes where the layouts differ from the norm, like Canvas, Afterburner and Magazine. Base-RTL on the other hand, also has a fair amount of .dir-rtl CSS styles, but these are placed in one rtl.css file with the exception of the menu-rtl.css which was easier to manage while working on this theme, but these could easily go into the rtl.css. This makes updating much easier. BASE-RTL theme is different insofar as it works in IE7 when logging in where current Moodle theme's don't. I know too that @HQ a decision was made to not continue with support for older browsers including IE7 & IE8, that said, it would be a pity to throw away this opportunity to prove to the RTL Moodle Community that Moodle is willing to go that extra mile to support Base-RTL that can become a parent theme for other themes to build upon, especially those who want RTL themes that will no only work in IE7 & IE8, but also be capable of swapping left and right columns when RTL is enabled, and also move the dock and the custommenu from left to right. Base-RTL is based on the Holy Grail Percentage Layout, and as such is, in my opinion the theme that should have been adopted in the first place. And also, if I may make so bold a statement, it is one that should be addopted as THE parent theme for future development in Moodle 2.4.
          Hide
          Martin Dougiamas added a comment -

          IE7 & IE8: What? AFAIK we have dropped support for IE6 only.

          Show
          Martin Dougiamas added a comment - IE7 & IE8: What? AFAIK we have dropped support for IE6 only.
          Hide
          Martin Dougiamas added a comment -

          Based on a quick read: if the issue here is that the base theme needs fixing to make it work better with RTL, then let's fix/replace the base theme. I don't think adding a new separate theme sounds like a good idea. It was already made confusing enough with the introduction of Canvas.

          Show
          Martin Dougiamas added a comment - Based on a quick read: if the issue here is that the base theme needs fixing to make it work better with RTL, then let's fix/replace the base theme. I don't think adding a new separate theme sounds like a good idea. It was already made confusing enough with the introduction of Canvas.
          Hide
          Mary Evans added a comment - - edited

          Martin,

          Forgive me if I got that wrong about IE7 & IE8, but I was under the impression these had been dropped, so sorry for that boo-boo!

          Canvas was built using a new set of divs in general.php and frontpage.php, and to this day I don't really understand why as base theme layout was adequate, and if anything, each individual theme should carry its own layouts if they differ so much from BASE theme, as does BASE-RTL.

          If you want to change Base theme to work in the same way as BASE-RTL you would need to introduce a new layout file in Base that uses BASE-RTL layout, and its coresponding CSS. Perhaps something as simple as base/layout/rtl.php and then add a new setting in base/config.php to use rtl.php when RTL is enabled.

          At the end of the day it is the subtle change in base_rtl's layout, and the fact it uses percentages, that makes it work better in Moodle.

          Show
          Mary Evans added a comment - - edited Martin, Forgive me if I got that wrong about IE7 & IE8, but I was under the impression these had been dropped, so sorry for that boo-boo! Canvas was built using a new set of divs in general.php and frontpage.php, and to this day I don't really understand why as base theme layout was adequate, and if anything, each individual theme should carry its own layouts if they differ so much from BASE theme, as does BASE-RTL. If you want to change Base theme to work in the same way as BASE-RTL you would need to introduce a new layout file in Base that uses BASE-RTL layout, and its coresponding CSS. Perhaps something as simple as base/layout/rtl.php and then add a new setting in base/config.php to use rtl.php when RTL is enabled. At the end of the day it is the subtle change in base_rtl's layout, and the fact it uses percentages, that makes it work better in Moodle.
          Hide
          Nadav Kavalerchik added a comment -

          Recent RTL updates I have made to theme/base:
          http://tracker.moodle.org/browse/MDL-32479
          Including Mary's fixes.

          I am in the process of fixing all themes and have them support RTL
          It is currently accumulated under: http://tracker.moodle.org/browse/MDL-30337
          It has an individual MDL issue for each theme and I will have a full "git pull diff"
          at the end of the process under a separate MDL issue.
          I am estimating the process will take me a week.

          I have just ask Patrick to have a look at one of the themes (afterburner) to generally review and approve the code changes in the general.php and frontpage.php layouts, since I am using the same hack on each theme.

          One thing i am not so much happy with...
          There is this issue with YUI3 menu that does not support RTL and i do not feel comfortable changing its code.
          So I am adopting Mary's menu_rtl hack, which seems to do the work.
          But if someone from Moodle HQ can dig this out and fix YUM3 menu... that would be great!

          Show
          Nadav Kavalerchik added a comment - Recent RTL updates I have made to theme/base: http://tracker.moodle.org/browse/MDL-32479 Including Mary's fixes. I am in the process of fixing all themes and have them support RTL It is currently accumulated under: http://tracker.moodle.org/browse/MDL-30337 It has an individual MDL issue for each theme and I will have a full "git pull diff" at the end of the process under a separate MDL issue. I am estimating the process will take me a week. I have just ask Patrick to have a look at one of the themes (afterburner) to generally review and approve the code changes in the general.php and frontpage.php layouts, since I am using the same hack on each theme. One thing i am not so much happy with... There is this issue with YUI3 menu that does not support RTL and i do not feel comfortable changing its code. So I am adopting Mary's menu_rtl hack, which seems to do the work. But if someone from Moodle HQ can dig this out and fix YUM3 menu... that would be great!
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Mary Evans added a comment - - edited

          Since I don't have much confidence that this theme, as it is, will ever make it into Moodle, I'm thinking of converting into Afterburner for Moodle 2.3.

          So I will start off by changing the menu using a renderer, as it looks and works a hundred times better in Afterburner than it does in BASE-RTL.

          At the end of the day, it is only the layout that is different.

          Show
          Mary Evans added a comment - - edited Since I don't have much confidence that this theme, as it is, will ever make it into Moodle, I'm thinking of converting into Afterburner for Moodle 2.3. So I will start off by changing the menu using a renderer, as it looks and works a hundred times better in Afterburner than it does in BASE-RTL. At the end of the day, it is only the layout that is different.
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          I have already used some of your code here: MDL-32481
          So if you are making a new MDL, please link it to MDL-32481

          Show
          Nadav Kavalerchik added a comment - @Mary I have already used some of your code here: MDL-32481 So if you are making a new MDL, please link it to MDL-32481
          Hide
          Mary Evans added a comment -

          @Nadav
          I have made this a sub-task of MDL-32481 so when you finally submit all CORE theme changes in your final push I'll follow it with mine.
          Cheers
          Mary

          Show
          Mary Evans added a comment - @Nadav I have made this a sub-task of MDL-32481 so when you finally submit all CORE theme changes in your final push I'll follow it with mine. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          Beautiful

          Show
          Nadav Kavalerchik added a comment - @Mary Beautiful
          Hide
          Mary Evans added a comment -

          Well this is finally finished and on the road to pave the way for all the other theme changes for RTL. Sorry it took me so long. Let's hope all goes will this time round.
          The code is lean and clean and looks good even though I say so myself! LOL

          Show
          Mary Evans added a comment - Well this is finally finished and on the road to pave the way for all the other theme changes for RTL. Sorry it took me so long. Let's hope all goes will this time round. The code is lean and clean and looks good even though I say so myself! LOL
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          Beautiful

          btw, I wonder if you can "fix" the annoying white/gray background color of the "list of options" that is displayed when clicking a SELECT form element, anywhere on the Afterburner, when using Chrome. (In Firefox it looks ok)

          Show
          Nadav Kavalerchik added a comment - @Mary Beautiful btw, I wonder if you can "fix" the annoying white/gray background color of the "list of options" that is displayed when clicking a SELECT form element, anywhere on the Afterburner, when using Chrome. (In Firefox it looks ok)
          Hide
          Mary Evans added a comment - - edited

          Nadav, can you give me the CSS then I can add it now? I don[t have Chrome installed, I removed it the other day when trying to find out why, when you "view image" in FireFox you get a dark background, where previously it was white. This lead me to discover, while using FireBug, that the body background used was being generated by Chrome using a Base64 image where the code stretched over about 100 lines!!! I thought it was a BUG so I uninstalled Chrome...LOL

          body {
              background: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFgAAABYBAMAAACDuy0HAAAAG1BMVEX+/v4BAQH///8KCgoDAwN/f3/19fWAgID8/PzhDwT2AAAACXRSTlMFBQUFBQUFBQWHDtP9AAALwklEQVR4Xg3KOWOyWhAA0Bn2ci57eXEvQY1JCZp8sQTjVoJLTAkaE0swbj/7ve4UB37FLW4q86Lwwlh86J/ASAkpWaj+Krbb31HzH0Kjc2tIl7SADaWbpZBPE5dds6jJNyNdjAyKWqdroIixWRQIY6E/kOY7hIciL/ZfrAO3XP/06AuUJ3mSd/z95OB9vIal0DPlaZWHP7RE6DIXjmKqKkuGr+xNZylOnj1GSlUKvnxZDBOIzTfMe0fJgJ7c/GIIOdUuKxYyBFUOzvY6AC5AXx8R+o5O4S0j0wqBND3ErIYm/XHFbQjtH1MXD5dUbp19OFdjkDlys+HSwrBgHRvL9wVN/pi8ViOIwcv/D1GRW6UuDvJLLQA5lCI17iUdsKYpOuYfMATGnpn/Zs3W6gov51G+/Vs9Ay//we5kh8uwvEPum6o5HkDMDb3ZWunwtq+UzENU8NphDdbvNtKM3knx5gi6UMSQl+eGs+27mraDtxeWdH+T62Us/GylEtr7Ct8jlbeXKvAf5onx8D2uVt1J/GblV+XQyKUInOUG44fqjcszK266yHWAAYG9ekhvy4l4Maa44jYVyV2RFEuS54e2HcswtmNdqR/+V4P0O9e4XnpWgxVSQkNXpYMCxJ4Vel0lmi56jnYIIJAQMndF+zTEiyuj92r3ijJT1O0alPQnLWJvJLR7Xx7Xg9fm9QOqFu8o29m3QQqFwZN4bki/RoprNtMKKtEET9iMsJyKpkiguAorn2yzkv0wG3M1EEVDJP5VN7muLjYCglzdGQ7boYGgRmorzhRDq83gglgylC+hBLEyy6ZQWNwCmmqt6PvExAqGEA9V2XIT4/fS+I2cx1n5td85kOCjHfPWTg72FJ/+vKOyggt+rytFbEDJWL+mPwpgw6HtFLIHmq4o2m1nZ9saKwiKEOTVZtWlnqHODPu949VfKD+zzpfynd/ZZU5IWZ0dgnqRHC4uOBpBsT8N7YbFJzADiW2eo/T979OKFxY8zk/+HR/NNEkzgSBsmA35Sayz1m/ubxgmYQOmffyRh9gdx42mUVX512oqWkfxAzyuSCxx1cywx3jIXuXJEEbssymo0xMy7SskJW9C5IPYroPwQunt7f5FEPPXJLWRbGHcL4Q3sx3TLAN6W672r/I5CKkL6zSwwk0AI8+iBCSv1Y7QQP5RSoLE227uy8vn22Y6dhLBgEsRh18cTGjIv3y+60Kmt3YAZQX8qf3bJDUc/5pdjti+KwAZ9GzzQzd23d1JBAnSvWkWB8YfsIGlspHitNiMPYPFfR+OecRuPyxgfoP9/HkR3cR27IohiaDXCk/3VNP6lIxP9TBnsMeAAUZloq6P8KURLBsNFuiA3LsN/d9qpCeKKIBgSzsN5k+rdh3uh0VbvMuOIomJD1fBOiCqIsvklS5bOQhMaahJC+Rc+6lz+Uvxmq05Py+LoGIQlLKvlcaHsFG9Ui66H/qdHz67sPRGho+ruC92QgN5JEMmLsZREEiJu78FJbyzT8FsdK90XoEcezn2R5iLUzZhczJmf1yNY3gJNJUQvbpTznTAbnV5J8iL4q2OWuhJEndWVTyEr8M5VGTWtvOmUo1DsnOsqXE5ZzKE8K4/8cl8+c1XArp1RUKz+iKP96j2FcUmA+v0HnEr0iUdSrRK5duAj1FQamvpiaXR2JddD6g8n4SyFx/fjT4LkC+ghJckj1e1wP+DrHrpIiMaPH5F1rcaRvwZWfEn6fx+/C7PdXABGLNKjr1USZ5XyHjsafXMEoXtguAfjykMioMMHISXVAc9yQY5o5Qg8MM0nhWCA2HoiEgBc1EH+warLjxH3Ln68M/ciFqI1bG0mBOxiNreOuShEf/9pIzhm1Bh2cbYVxn2IYQ7eljYpab/5EdPF2PSmcy+62j6e2HBPNbe+8JVMuRQBrWdL9uBh4bYbQaQJ07FyfcpCuvSuxUyYjP6avvw9gTcAj0uTVohSwOHDDaHTs8nyachMBcWoVDWp3/lWgqeCLMneAUhSuhD2RJpufLOSi7emxOVhYsOGomV2JCEKjWu7kuqwueyFEmDgVhR0l4oHn8W87UZuxb8id54SxHWiSnPKnMyAhzdhi2wN/AoH3OYwLajuybB8h/QeJJiX1gIt+dfij+gr0CJRXQ2Y04Q6q8xHzfWm9FIgchiW0+X86tIotIGzRG1gENaKokQkLn+FXZ2x3KUcp7d/NUsmOmFCG/i03YB8pi0eiNS4LUIfA06AKvfQmP/VAXS1AP2kzJ+9LAaTafvFyO7bz8U9OCpld2q1eHGts+ZFrt04AmIlubOPP7Xayfi/r0tiX2aaPT9Dz4+TVPBoXsjHDzWfrmawOsZfmBT/k2+c6sz/hvD5wjrjT7XgRlnEzPuZermi1jqfUrE3q7VdFfJu5oT9Ad+VUh1fIwIFhBy8TmMuhIeX2XpmogmvS1C3ZuwiyR87ZSrj0Jv1DpEAYkbcL3RpjZXmZpPV4mXH8z8Nh8CS+R+PpcTnkhyr5UJaSiz0wjK22Ewl+zS+pTug0PQ0CSnJQ5LfdR77vVZufgjkQ/ydf4V5zpEaNq+JZmrQK6WdZBacmMHL9RmLnPUs0/MYwYFzoyrXYQMTHGAUJOfumR5r79MZO28DIEXQVT5wGw99TY1T0GOCC/BzWv8READwICd0LjUNKnE6ORVa0lOnqhoO0v33lwWcwF0ynTgTpFxy+0OKdphNDWJlH8ubKoG6WJXtKxAwbsilpBJB+GBwimvTsCrv1R7LSX9ExkAw44ZEcxU3L50OHnKAyKZNe1fih+hVqItRGCDf7shuvme+lTWteX5oYuc58NrCaqjYIrIV0PFyQeh2ZzZEqNS60LuhnP5wweMkkaU93pDA/RWPNeGpPCBgiUeDvV0L1NfdRP/Hn5i7rUK7kftlIWeIUIYbtzzFl9nlIeaNfoX+x/qyWzIABLTZDbeq/hDZpxg2gkh+ICfSU8OUpJ8yWY17uQ5EGa+GGWFmnrBd9vX3KOteYkJaMpPwJ4TjzDjbhkOMKmWKClzVJ2g81YGFl/c0xPIKncgJGdUKvZoUUJu0gYaIAh6E0xNeQ15qpJXzNITgf4W+w/oUaKOM54EMUi1j5yvOCsEe8JYpwVGj53lNiPMY9Rltgd4icp82fvN69zkSBUI40nJSRTeHz7h1IX42Cr0klWjxjO05MSX1IaTeDmTRGEeKvAvtaaBaLQnjftGJz+4cjFyy6/iCjLGF2/gW+jQhEUxbEBPyQzXi+Bb4kc9wK4jIwNLWbwQAOtYKRLaipDH+X4TPPOG8DCNY4IC9yBk1qcibjhUgRnDcf35pl9d5otbvQjOIXlEu5dVtm5LRaK5KWcD/PX6LaGd25CuNHG/vgeIB1kcpCme+J8idlcjfBALAJSggznsGHGOAJgdGduMnZg+bAaeGASGV9bh/X2wPsVTmBLxmTTQsBGFkEOkZJTsGAm+HrtMDbWwvTXOutX1u7BxIq9Xib6DkFMbUitNdrYsULkahsAhBEh9FjdzL9BNARxTSr7T3u1rE+IWUmCIpwTZHZCu5l9THCuCcOhZqfekuQxjQ7EoyGUJAwCv/q1JOuJeCc/3lknb76zAquO/DAQhK/62cP8X2s3+IBLIhvL8RHopoHpIArJysYTTmMMeubPXh8W760AvMVH67jqgg06+/ne5MZ631z6yROhloh3dPQirZoEpr80wgt/cEbhbAQTmRLtGh8lxCwDBBb5OeJ4aEq25XBNMT2rzWedW2zIzj+CCDKlnlyJBzT81qBWp69h7vlb3TmEV+DNm2rqj1iT7BQuwVVsuPkwq1e5P8tgNjVbIlMzwXeM11kZqjx3KKFOJzc3CAyFVhi8fxVZ5FvhdAM5mM6kS6OgKu16MFglq3/b/QVIwdw7HUCyeW04JPjC5dO+GC9OfqfB4VX+wwuift+ths2Ss3i6nkOE+JFyD+wKFL+WMX6nwwDva0S1/O8Mlnida69Ph96fuFvCoRMvXnCfsLPPmC/hA5RnMNE4fDK0pVOQ4BHLaErzv/wD99ABmjNZk0AAAAABJRU5ErkJggg==") repeat scroll 0 0 #222222;
          }
          

          SCARY!

          Show
          Mary Evans added a comment - - edited Nadav, can you give me the CSS then I can add it now? I don[t have Chrome installed, I removed it the other day when trying to find out why, when you "view image" in FireFox you get a dark background, where previously it was white. This lead me to discover, while using FireBug, that the body background used was being generated by Chrome using a Base64 image where the code stretched over about 100 lines!!! I thought it was a BUG so I uninstalled Chrome...LOL body { background: url( "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFgAAABYBAMAAACDuy0HAAAAG1BMVEX+/v4BAQH ///8KCgoDAwN/f3/19fWAgID8/PzhDwT2AAAACXRSTlMFBQUFBQUFBQWHDtP9AAALwklEQVR4Xg3KOWOyWhAA0Bn2ci57eXEvQY1JCZp8sQTjVoJLTAkaE0swbj/7ve4UB37FLW4q86Lwwlh86J/ASAkpWaj+Krbb31HzH0Kjc2tIl7SADaWbpZBPE5dds6jJNyNdjAyKWqdroIixWRQIY6E/kOY7hIciL/ZfrAO3XP/06AuUJ3mSd/z95OB9vIal0DPlaZWHP7RE6DIXjmKqKkuGr+xNZylOnj1GSlUKvnxZDBOIzTfMe0fJgJ7c/GIIOdUuKxYyBFUOzvY6AC5AXx8R+o5O4S0j0wqBND3ErIYm/XHFbQjtH1MXD5dUbp19OFdjkDlys+HSwrBgHRvL9wVN/pi8ViOIwcv/D1GRW6UuDvJLLQA5lCI17iUdsKYpOuYfMATGnpn/Zs3W6gov51G+/Vs9Ay//we5kh8uwvEPum6o5HkDMDb3ZWunwtq+UzENU8NphDdbvNtKM3knx5gi6UMSQl+eGs+27mraDtxeWdH+T62Us/GylEtr7Ct8jlbeXKvAf5onx8D2uVt1J/GblV+XQyKUInOUG44fqjcszK266yHWAAYG9ekhvy4l4Maa44jYVyV2RFEuS54e2HcswtmNdqR/+V4P0O9e4XnpWgxVSQkNXpYMCxJ4Vel0lmi56jnYIIJAQMndF+zTEiyuj92r3ijJT1O0alPQnLWJvJLR7Xx7Xg9fm9QOqFu8o29m3QQqFwZN4bki/RoprNtMKKtEET9iMsJyKpkiguAorn2yzkv0wG3M1EEVDJP5VN7muLjYCglzdGQ7boYGgRmorzhRDq83gglgylC+hBLEyy6ZQWNwCmmqt6PvExAqGEA9V2XIT4/fS+I2cx1n5td85kOCjHfPWTg72FJ/+vKOyggt+rytFbEDJWL+mPwpgw6HtFLIHmq4o2m1nZ9saKwiKEOTVZtWlnqHODPu949VfKD+zzpfynd/ZZU5IWZ0dgnqRHC4uOBpBsT8N7YbFJzADiW2eo/T979OKFxY8zk/+HR/NNEkzgSBsmA35Sayz1m/ubxgmYQOmffyRh9gdx42mUVX512oqWkfxAzyuSCxx1cywx3jIXuXJEEbssymo0xMy7SskJW9C5IPYroPwQunt7f5FEPPXJLWRbGHcL4Q3sx3TLAN6W672r/I5CKkL6zSwwk0AI8+iBCSv1Y7QQP5RSoLE227uy8vn22Y6dhLBgEsRh18cTGjIv3y+60Kmt3YAZQX8qf3bJDUc/5pdjti+KwAZ9GzzQzd23d1JBAnSvWkWB8YfsIGlspHitNiMPYPFfR+OecRuPyxgfoP9/HkR3cR27IohiaDXCk/3VNP6lIxP9TBnsMeAAUZloq6P8KURLBsNFuiA3LsN/d9qpCeKKIBgSzsN5k+rdh3uh0VbvMuOIomJD1fBOiCqIsvklS5bOQhMaahJC+Rc+6lz+Uvxmq05Py+LoGIQlLKvlcaHsFG9Ui66H/qdHz67sPRGho+ruC92QgN5JEMmLsZREEiJu78FJbyzT8FsdK90XoEcezn2R5iLUzZhczJmf1yNY3gJNJUQvbpTznTAbnV5J8iL4q2OWuhJEndWVTyEr8M5VGTWtvOmUo1DsnOsqXE5ZzKE8K4/8cl8+c1XArp1RUKz+iKP96j2FcUmA+v0HnEr0iUdSrRK5duAj1FQamvpiaXR2JddD6g8n4SyFx/fjT4LkC+ghJckj1e1wP+DrHrpIiMaPH5F1rcaRvwZWfEn6fx+/C7PdXABGLNKjr1USZ5XyHjsafXMEoXtguAfjykMioMMHISXVAc9yQY5o5Qg8MM0nhWCA2HoiEgBc1EH+warLjxH3Ln68M/ciFqI1bG0mBOxiNreOuShEf/9pIzhm1Bh2cbYVxn2IYQ7eljYpab/5EdPF2PSmcy+62j6e2HBPNbe+8JVMuRQBrWdL9uBh4bYbQaQJ07FyfcpCuvSuxUyYjP6avvw9gTcAj0uTVohSwOHDDaHTs8nyachMBcWoVDWp3/lWgqeCLMneAUhSuhD2RJpufLOSi7emxOVhYsOGomV2JCEKjWu7kuqwueyFEmDgVhR0l4oHn8W87UZuxb8id54SxHWiSnPKnMyAhzdhi2wN/AoH3OYwLajuybB8h/QeJJiX1gIt+dfij+gr0CJRXQ2Y04Q6q8xHzfWm9FIgchiW0+X86tIotIGzRG1gENaKokQkLn+FXZ2x3KUcp7d/NUsmOmFCG/i03YB8pi0eiNS4LUIfA06AKvfQmP/VAXS1AP2kzJ+9LAaTafvFyO7bz8U9OCpld2q1eHGts+ZFrt04AmIlubOPP7Xayfi/r0tiX2aaPT9Dz4+TVPBoXsjHDzWfrmawOsZfmBT/k2+c6sz/hvD5wjrjT7XgRlnEzPuZermi1jqfUrE3q7VdFfJu5oT9Ad+VUh1fIwIFhBy8TmMuhIeX2XpmogmvS1C3ZuwiyR87ZSrj0Jv1DpEAYkbcL3RpjZXmZpPV4mXH8z8Nh8CS+R+PpcTnkhyr5UJaSiz0wjK22Ewl+zS+pTug0PQ0CSnJQ5LfdR77vVZufgjkQ/ydf4V5zpEaNq+JZmrQK6WdZBacmMHL9RmLnPUs0/MYwYFzoyrXYQMTHGAUJOfumR5r79MZO28DIEXQVT5wGw99TY1T0GOCC/BzWv8READwICd0LjUNKnE6ORVa0lOnqhoO0v33lwWcwF0ynTgTpFxy+0OKdphNDWJlH8ubKoG6WJXtKxAwbsilpBJB+GBwimvTsCrv1R7LSX9ExkAw44ZEcxU3L50OHnKAyKZNe1fih+hVqItRGCDf7shuvme+lTWteX5oYuc58NrCaqjYIrIV0PFyQeh2ZzZEqNS60LuhnP5wweMkkaU93pDA/RWPNeGpPCBgiUeDvV0L1NfdRP/Hn5i7rUK7kftlIWeIUIYbtzzFl9nlIeaNfoX+x/qyWzIABLTZDbeq/hDZpxg2gkh+ICfSU8OUpJ8yWY17uQ5EGa+GGWFmnrBd9vX3KOteYkJaMpPwJ4TjzDjbhkOMKmWKClzVJ2g81YGFl/c0xPIKncgJGdUKvZoUUJu0gYaIAh6E0xNeQ15qpJXzNITgf4W+w/oUaKOM54EMUi1j5yvOCsEe8JYpwVGj53lNiPMY9Rltgd4icp82fvN69zkSBUI40nJSRTeHz7h1IX42Cr0klWjxjO05MSX1IaTeDmTRGEeKvAvtaaBaLQnjftGJz+4cjFyy6/iCjLGF2/gW+jQhEUxbEBPyQzXi+Bb4kc9wK4jIwNLWbwQAOtYKRLaipDH+X4TPPOG8DCNY4IC9yBk1qcibjhUgRnDcf35pl9d5otbvQjOIXlEu5dVtm5LRaK5KWcD/PX6LaGd25CuNHG/vgeIB1kcpCme+J8idlcjfBALAJSggznsGHGOAJgdGduMnZg+bAaeGASGV9bh/X2wPsVTmBLxmTTQsBGFkEOkZJTsGAm+HrtMDbWwvTXOutX1u7BxIq9Xib6DkFMbUitNdrYsULkahsAhBEh9FjdzL9BNARxTSr7T3u1rE+IWUmCIpwTZHZCu5l9THCuCcOhZqfekuQxjQ7EoyGUJAwCv/q1JOuJeCc/3lknb76zAquO/DAQhK/62cP8X2s3+IBLIhvL8RHopoHpIArJysYTTmMMeubPXh8W760AvMVH67jqgg06+/ne5MZ631z6yROhloh3dPQirZoEpr80wgt/cEbhbAQTmRLtGh8lxCwDBBb5OeJ4aEq25XBNMT2rzWedW2zIzj+CCDKlnlyJBzT81qBWp69h7vlb3TmEV+DNm2rqj1iT7BQuwVVsuPkwq1e5P8tgNjVbIlMzwXeM11kZqjx3KKFOJzc3CAyFVhi8fxVZ5FvhdAM5mM6kS6OgKu16MFglq3/b/QVIwdw7HUCyeW04JPjC5dO+GC9OfqfB4VX+wwuift+ths2Ss3i6nkOE+JFyD+wKFL+WMX6nwwDva0S1/O8Mlnida69Ph96fuFvCoRMvXnCfsLPPmC/hA5RnMNE4fDK0pVOQ4BHLaErzv/wD99ABmjNZk0AAAAABJRU5ErkJggg==" ) repeat scroll 0 0 #222222; } SCARY!
          Hide
          Nadav Kavalerchik added a comment -

          Indeed funny (Scary)

          I am not sure what the original intent was for the combination of "background color + text color" for the SELECT input element, throughout the theme, but it looks more "usable" when removing:

          select, button {
          background-color: #34637F;
          color: white;
          }
          

          at least for the Chrome users. (It might be a Chrome CSS rendering bug)

          Show
          Nadav Kavalerchik added a comment - Indeed funny (Scary) I am not sure what the original intent was for the combination of "background color + text color" for the SELECT input element, throughout the theme, but it looks more "usable" when removing: select, button { background-color: #34637F; color: white; } at least for the Chrome users. (It might be a Chrome CSS rendering bug)
          Hide
          Mary Evans added a comment - - edited

          When I made this theme, I wanted all the buttons to be colored, but some buttons are created using select, so I just put that CSS as a general thing to style buttons and select (go) buttons, I did not realise it would colour all the forms too. But I like the look of it...it's different.

          However you are only one of two people who have asked to change this. And yet there are a lot of people using Afterburner out there.

          In that case I will take the select off and leave the button, as I like that better.

          Thanks for telling me about Chrome...I'll re-install it and test this later.

          Show
          Mary Evans added a comment - - edited When I made this theme, I wanted all the buttons to be colored, but some buttons are created using select, so I just put that CSS as a general thing to style buttons and select (go) buttons, I did not realise it would colour all the forms too. But I like the look of it...it's different. However you are only one of two people who have asked to change this. And yet there are a lot of people using Afterburner out there. In that case I will take the select off and leave the button, as I like that better. Thanks for telling me about Chrome...I'll re-install it and test this later.
          Hide
          Nadav Kavalerchik added a comment -

          I LOVE the design and the color!
          I just thought we should fix it so Chrome gets it too
          Do not remove it

          Show
          Nadav Kavalerchik added a comment - I LOVE the design and the color! I just thought we should fix it so Chrome gets it too Do not remove it
          Hide
          Mary Evans added a comment -

          I tested it in Chrome and it works OK for the form background color. The only thing that des not work in Chrome in RTL is the docked titles. There are converted to svg and look to be offset by about 10px but you cannot see them. It is as though the color is transparent! But everything else seems to look and work like it does in FireFox!

          Google Chrome version 20.0.1132.57 m installed about 2 hours ago.

          Show
          Mary Evans added a comment - I tested it in Chrome and it works OK for the form background color. The only thing that des not work in Chrome in RTL is the docked titles. There are converted to svg and look to be offset by about 10px but you cannot see them. It is as though the color is transparent! But everything else seems to look and work like it does in FireFox! Google Chrome version 20.0.1132.57 m installed about 2 hours ago.
          Hide
          Nadav Kavalerchik added a comment -

          I saw the DOCK svg issue too. It's a Chrome issue with SVG and it is reported on Chrome's bug tracker.
          No need to change anything in the themes for that.
          In Firefox it looks OK.

          I might have some kind of a bug in my GNU/Linux Chrome version ( I am not using Windows )
          I'll check this issue with some fellow developers to see if it is my own malfunctioning browser.

          Show
          Nadav Kavalerchik added a comment - I saw the DOCK svg issue too. It's a Chrome issue with SVG and it is reported on Chrome's bug tracker. No need to change anything in the themes for that. In Firefox it looks OK. I might have some kind of a bug in my GNU/Linux Chrome version ( I am not using Windows ) I'll check this issue with some fellow developers to see if it is my own malfunctioning browser.
          Hide
          Mary Evans added a comment -

          @Nadav

          I have just pushed one more commit with more fixes for .dir-rtl #custommenu hover which also includes a new image and re-nameing another one.

          I think that concludes all the fixes for this theme for the time being.

          Show
          Mary Evans added a comment - @Nadav I have just pushed one more commit with more fixes for .dir-rtl #custommenu hover which also includes a new image and re-nameing another one. I think that concludes all the fixes for this theme for the time being.
          Hide
          Nadav Kavalerchik added a comment -

          Where can i see those changes?
          (Will i see it if i pull your personal github moodle project account?)

          Show
          Nadav Kavalerchik added a comment - Where can i see those changes? (Will i see it if i pull your personal github moodle project account?)
          Hide
          Mary Evans added a comment -

          @Nadav
          Use...

          git fetch git://github.com/lazydaisy/moodle.git MDL-32412_master
          
          git checkout -b mary-MDL-32412_master FETCH_HEAD
          
          Show
          Mary Evans added a comment - @Nadav Use... git fetch git: //github.com/lazydaisy/moodle.git MDL-32412_master git checkout -b mary-MDL-32412_master FETCH_HEAD
          Hide
          Mary Evans added a comment - - edited

          @Dan

          As I missed the 2.3 release with these changes, I was not sure if this can go into 2.3.2 or just 2.4?

          If 2.3.2 that would be great, it will cherry-pick easy enough.

          Show
          Mary Evans added a comment - - edited @Dan As I missed the 2.3 release with these changes, I was not sure if this can go into 2.3.2 or just 2.4? If 2.3.2 that would be great, it will cherry-pick easy enough.
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          I'm reopening this at the moment sorry, there are still a few things to tidy up and I think we really need to have a clear plan about things.
          I'll raise things below, please if you could have a look at them and reply that would be great.

          First up noted issues (I played with this theme for about an hour and picked these up). Testing done in Chrome .

          1. Region post content seems to be indented incorrectly, everything is pushed a percentage too far to the right. Leads to the right hand side of the blocks be hidden.
          2. When the dock is being displayed and your browser width is less than the min-width (so you get horizontal scroll) the display of the dock title gets messed up. Not sure what the best option is here, perhaps to adjust the min width by the width of the dock when its in use and then make sure its placement is repected.
          3. Funny vertical scroll bar when viewing admin pages. Seems to happen on all admin pages but tested on advanced features.
          4. Table on course enrolments page needs borders. Same with other tables in the course area actually, participants, backup/restore, user permissions, reports, etc...
          5. Select boxes unusable, options are white text on white background.

          In general I think the following points need some discussion or explanations.

          1. Why the shift to a percentage width layout?
          To be truthful I am really not a fan of percentage layouts. They are too inconsistent for my liking.
          When things are around the same size, resolution as that of the developers it all works, however in situations where they aren't in the same area start to look out of place and not nearly as polished.
          Sitting here right now I have a development site using the theme open in a browser on one monitor. At 1920*1080 resolution the block regions are MASSIC, lots of wasted space.
          Really that inconsistent space + that we wanted content to have the focus (only the content expands and contracts as it does with a fixed width layout) are why we chose to use fixed width layouts in 2.0.
          I'm not saying its not allowed, I'm just curious why you chose to do it.

          2. What is the plan for the rest of the theme's in regards to the right_to_left changes made for this theme?
          I ask this because I think we really need to know what is being planned, is the plan to use this theme as a model for the other core themes? If so what changes been made here are required and what are not? also if that is the plan we should really consider what is being done here.
          The following question runs on from this.

          3 You are flipping the block regions for rtl languages so that region pre is rendered where region post is and vice-versa. Three things strike me when looking at this.

          a. For rtl users who have moved things around to the way they like them will be inconvienienced when upgrading their sites.
          b. If we are going to do this we need to consider how to do it for all themes so that similar themes are consistent. We could do this internally and it would help the following point. Although there would be complexities and difficulties when using multiple or alternative block regions.
          c. We need to find some way to encompass and simplfy that logic to switch the regions. Looking at that I think it is above the average developer and for sure we could simplfy it.

          I think your answers to to question 1 and 2 will probably have a big impact on what is decided here.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I'm reopening this at the moment sorry, there are still a few things to tidy up and I think we really need to have a clear plan about things. I'll raise things below, please if you could have a look at them and reply that would be great. First up noted issues (I played with this theme for about an hour and picked these up). Testing done in Chrome . Region post content seems to be indented incorrectly, everything is pushed a percentage too far to the right. Leads to the right hand side of the blocks be hidden. When the dock is being displayed and your browser width is less than the min-width (so you get horizontal scroll) the display of the dock title gets messed up. Not sure what the best option is here, perhaps to adjust the min width by the width of the dock when its in use and then make sure its placement is repected. Funny vertical scroll bar when viewing admin pages. Seems to happen on all admin pages but tested on advanced features. Table on course enrolments page needs borders. Same with other tables in the course area actually, participants, backup/restore, user permissions, reports, etc... Select boxes unusable, options are white text on white background. In general I think the following points need some discussion or explanations. 1. Why the shift to a percentage width layout? To be truthful I am really not a fan of percentage layouts. They are too inconsistent for my liking. When things are around the same size, resolution as that of the developers it all works, however in situations where they aren't in the same area start to look out of place and not nearly as polished. Sitting here right now I have a development site using the theme open in a browser on one monitor. At 1920*1080 resolution the block regions are MASSIC, lots of wasted space. Really that inconsistent space + that we wanted content to have the focus (only the content expands and contracts as it does with a fixed width layout) are why we chose to use fixed width layouts in 2.0. I'm not saying its not allowed, I'm just curious why you chose to do it. 2. What is the plan for the rest of the theme's in regards to the right_to_left changes made for this theme? I ask this because I think we really need to know what is being planned, is the plan to use this theme as a model for the other core themes? If so what changes been made here are required and what are not? also if that is the plan we should really consider what is being done here. The following question runs on from this. 3 You are flipping the block regions for rtl languages so that region pre is rendered where region post is and vice-versa. Three things strike me when looking at this. a. For rtl users who have moved things around to the way they like them will be inconvienienced when upgrading their sites. b. If we are going to do this we need to consider how to do it for all themes so that similar themes are consistent. We could do this internally and it would help the following point. Although there would be complexities and difficulties when using multiple or alternative block regions. c. We need to find some way to encompass and simplfy that logic to switch the regions. Looking at that I think it is above the average developer and for sure we could simplfy it. I think your answers to to question 1 and 2 will probably have a big impact on what is decided here. Cheers Sam
          Hide
          Mary Evans added a comment -

          I think, without a doubt that you are being a bit picky with this Sam.
          The theme in general has not changed one iota. I only changed the layout.
          Granted I should have added a min/max width on the side blocks, big deal!

          I do feel for the RTL communities around the world, as whatever suggestion we put forward gets side swipped.

          Show
          Mary Evans added a comment - I think, without a doubt that you are being a bit picky with this Sam. The theme in general has not changed one iota. I only changed the layout. Granted I should have added a min/max width on the side blocks, big deal! I do feel for the RTL communities around the world, as whatever suggestion we put forward gets side swipped.
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          This wasn't meant to offend or any such thing.

          If the noted bugs were already existing that is fine, we can note them as such and open further issues to fix them.

          I am in absolute agreement that RTL support needs some TLC, as far as I'm aware we need to fix it in all of our themes, and I assume that these changes are part of a bigger plan to do so.
          I honestly feel that it would be beneficial to know what the plan is here, hence the questions. I am really just looking to clarify things so that we can make sure that the whole thing makes sense and so that myself plus the other integrators know what is going on as I assume more changes will land for other themes (perhaps I am assuming to much, you tell me).
          By the way I have not said that these changes cannot land, I have sent this back because a. I noted some issue while using the theme and b. to dig deeper about the nature of these changes and the big plan.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, This wasn't meant to offend or any such thing. If the noted bugs were already existing that is fine, we can note them as such and open further issues to fix them. I am in absolute agreement that RTL support needs some TLC, as far as I'm aware we need to fix it in all of our themes, and I assume that these changes are part of a bigger plan to do so. I honestly feel that it would be beneficial to know what the plan is here, hence the questions. I am really just looking to clarify things so that we can make sure that the whole thing makes sense and so that myself plus the other integrators know what is going on as I assume more changes will land for other themes (perhaps I am assuming to much, you tell me). By the way I have not said that these changes cannot land, I have sent this back because a. I noted some issue while using the theme and b. to dig deeper about the nature of these changes and the big plan. Cheers Sam
          Hide
          Mary Evans added a comment -

          Hi,

          Sorry...I just get carried away...just put it down to my latin temperament.

          #region-post left: 78% is a typo should be 75%
          also adding max-width: 210px and min-width: 210px fixes the wide screen problem.
          Perhaps an overall max-width would be a good idea too.

          The reason for this particular layout was, originally, to get over the IE7 login problem when in RTL language. See MDL-26400. If you test it in IE7 it works.

          Nadav is better at explaining what we are trying to achieve when swapping sides. I am not sure, but I think it is more to do with default regions. RTL needs the default on the opposite side of the page to LTR.

          Show
          Mary Evans added a comment - Hi, Sorry...I just get carried away...just put it down to my latin temperament. #region-post left: 78% is a typo should be 75% also adding max-width: 210px and min-width: 210px fixes the wide screen problem. Perhaps an overall max-width would be a good idea too. The reason for this particular layout was, originally, to get over the IE7 login problem when in RTL language. See MDL-26400 . If you test it in IE7 it works. Nadav is better at explaining what we are trying to achieve when swapping sides. I am not sure, but I think it is more to do with default regions. RTL needs the default on the opposite side of the page to LTR.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Nadav Kavalerchik added a comment -

          I agree with Mary. This theme is one of the most used amongst the RTL community. and should be adopted to work in RTL mode.

          One of the main issues, is the ability to switch the "Block Column" from left side to the right side when switching to Hebrew (or Arabic or Farsi or... any RTL language) since we (RTL users) read everything from right to left. and it feels wrong and confusing to have only the content of the blocks change to RTL and not the placement of the blocks, inside the entire page layout. (As it used to be on Moodle 1.9.x)

          Although IE7 is quickly fading away, we should support it. All because the Educational sector is the least advanced (browser wise) sector (Yes, ironic), at least in Israel.

          @Sam
          Regarding your number (3) remarks:
          3(a) Switching from Moodle 19 to 2+ was confusing, since the blocks stop switching when in RTL mode.

          3(b) There are many waiting for testing/integration fixed themes for Moodle 2.2 (that needs to be rebased by me to latest Moodle 2.3 / 2.4, soon) at : MDL-30337

          3(c) I would LOVE if it was possible to deal with the "Blocks Column Switch" for the RTL mode at some deeper API level and not just switch "post" with "pre". Especially, since they are not truly right side and left side. they are just regions for blocks that can be layout anywhere. (And there are some complex layout themes i ran into already. In which the right and left blocks are not that clear to distinguish). btw, checkout MDL-31777

          We also have issues with YUI3 that does not support RTL (the custom-menu) and TinyMCE's internal CSSes that are very hard to override so the modal dialogs that pop out off the TinyMCE UI be aligned to the right (I really LOVE to read your thoughts on these issues)

          Show
          Nadav Kavalerchik added a comment - I agree with Mary. This theme is one of the most used amongst the RTL community. and should be adopted to work in RTL mode. One of the main issues, is the ability to switch the "Block Column" from left side to the right side when switching to Hebrew (or Arabic or Farsi or... any RTL language) since we (RTL users) read everything from right to left. and it feels wrong and confusing to have only the content of the blocks change to RTL and not the placement of the blocks, inside the entire page layout. (As it used to be on Moodle 1.9.x) Although IE7 is quickly fading away, we should support it. All because the Educational sector is the least advanced (browser wise) sector (Yes, ironic), at least in Israel. @Sam Regarding your number (3) remarks: 3(a) Switching from Moodle 19 to 2+ was confusing, since the blocks stop switching when in RTL mode. 3(b) There are many waiting for testing/integration fixed themes for Moodle 2.2 (that needs to be rebased by me to latest Moodle 2.3 / 2.4, soon) at : MDL-30337 3(c) I would LOVE if it was possible to deal with the "Blocks Column Switch" for the RTL mode at some deeper API level and not just switch "post" with "pre". Especially, since they are not truly right side and left side. they are just regions for blocks that can be layout anywhere. (And there are some complex layout themes i ran into already. In which the right and left blocks are not that clear to distinguish). btw, checkout MDL-31777 We also have issues with YUI3 that does not support RTL (the custom-menu) and TinyMCE's internal CSSes that are very hard to override so the modal dialogs that pop out off the TinyMCE UI be aligned to the right (I really LOVE to read your thoughts on these issues)
          Hide
          Mary Evans added a comment -

          @Sam
          I have just commited some changes to fix what was wrong in region-post (left:75%; instead of 78% and added max/min widths of 210px for regions-pre/region-post and page-wrapper so that the overall page with will not exceed 1375px

          I have also named you as Peer reviewer - hope that's OK?

          Show
          Mary Evans added a comment - @Sam I have just commited some changes to fix what was wrong in region-post (left:75%; instead of 78% and added max/min widths of 210px for regions-pre/region-post and page-wrapper so that the overall page with will not exceed 1375px I have also named you as Peer reviewer - hope that's OK?
          Hide
          Mary Evans added a comment -

          @Sam

          In answer to Point 3 of your questions above:

          I have no plans to change any CORE themes to this particular layout, but I would argue a need to have at least ONE theme that is RTL language specific. I would rather maintain Afterburner and get it to become one of the best in Moodle for this purpose alone.

          Another point to make also is that Martin did say in the original discussion, when I tried to introduce this layout as a Parent theme in MDL-32412, that it is confusing enough with canvas theme. If any changes need to be made, to make RTL work better, then make changes to BASE theme.

          This, as you can well imagine, would not be easy and not workable without a lot of individual theme changes. So that was out of the question. So if anything this is a compromise. We just need help from the developers to see and appreciate this.

          Show
          Mary Evans added a comment - @Sam In answer to Point 3 of your questions above: I have no plans to change any CORE themes to this particular layout, but I would argue a need to have at least ONE theme that is RTL language specific. I would rather maintain Afterburner and get it to become one of the best in Moodle for this purpose alone. Another point to make also is that Martin did say in the original discussion, when I tried to introduce this layout as a Parent theme in MDL-32412 , that it is confusing enough with canvas theme. If any changes need to be made, to make RTL work better, then make changes to BASE theme. This, as you can well imagine, would not be easy and not workable without a lot of individual theme changes. So that was out of the question. So if anything this is a compromise. We just need help from the developers to see and appreciate this.
          Hide
          Mary Evans added a comment -

          @Nadav
          I have come across a page layout problem when in RTL. The body classes don't appear to be working correctly, which makes me suspect this is a similar problem to MDL-34496 with docks and blocks and custom regions. Unless it is just the coding in the body class area in layout/default.php?

          The fact we are swapping $OUTPUT->side-pre with $OUTPUT->side-post seems to be confusing moodle. I hope I am wrong, but I got a problem this evening when making some changes when in RTL, where it should have had a side-pre-only bodyclass but was displaying a full page layout instead. The right-hand column was still showing, so I am wondering is there really a need to change body classes for RTL as the swap is changing output not the actual layout. As I see it when a page is in side-pre-only state (left side only) the output in RTL is side-post, it's NOT side-post-only (which Moodle thinks it obviously is). So the body classes can stay the same as they were originally, without needing any changes.

          After this weekend I am going to take a break until September. It was my birthday the other day and now I am feeling really ancient! LOL

          Show
          Mary Evans added a comment - @Nadav I have come across a page layout problem when in RTL. The body classes don't appear to be working correctly, which makes me suspect this is a similar problem to MDL-34496 with docks and blocks and custom regions. Unless it is just the coding in the body class area in layout/default.php? The fact we are swapping $OUTPUT->side-pre with $OUTPUT->side-post seems to be confusing moodle. I hope I am wrong, but I got a problem this evening when making some changes when in RTL, where it should have had a side-pre-only bodyclass but was displaying a full page layout instead. The right-hand column was still showing, so I am wondering is there really a need to change body classes for RTL as the swap is changing output not the actual layout. As I see it when a page is in side-pre-only state (left side only) the output in RTL is side-post, it's NOT side-post-only (which Moodle thinks it obviously is). So the body classes can stay the same as they were originally, without needing any changes. After this weekend I am going to take a break until September. It was my birthday the other day and now I am feeling really ancient! LOL
          Hide
          Mary Evans added a comment -

          I forgot to say I have also made some changes to the dock and will commit them over the weekend. I have changed the way it works and looks...slightly.

          Show
          Mary Evans added a comment - I forgot to say I have also made some changes to the dock and will commit them over the weekend. I have changed the way it works and looks...slightly.
          Hide
          Mary Evans added a comment -

          Panic over..not sure what the problem was, but it's all working smoothly now. All the RTL body class code is intact and working.

          Show
          Mary Evans added a comment - Panic over..not sure what the problem was, but it's all working smoothly now. All the RTL body class code is intact and working.
          Hide
          Nadav Kavalerchik added a comment -

          Mary I am shutting down myself for the entire August ("season") thought it was not my birthday (Happy birthday!!!) I feel like I need a break too.

          So, I was happy to hear that the RTL was not broken. and I am sure we will continue where I (we) left off, with all the other themes too. See you (all) in September

          Show
          Nadav Kavalerchik added a comment - Mary I am shutting down myself for the entire August ("season") thought it was not my birthday (Happy birthday!!!) I feel like I need a break too. So, I was happy to hear that the RTL was not broken. and I am sure we will continue where I (we) left off, with all the other themes too. See you (all) in September
          Hide
          Mary Evans added a comment - - edited

          @Nadav
          Enjoy your well earned break.

          I have just re-submitted it as one commit.

          https://github.com/lazydaisy/moodle/tree/wip_MDL-32412_afterburner

          Show
          Mary Evans added a comment - - edited @Nadav Enjoy your well earned break. I have just re-submitted it as one commit. https://github.com/lazydaisy/moodle/tree/wip_MDL-32412_afterburner
          Hide
          Mary Evans added a comment -

          @Sam

          Regarding the display problems you highlighted above
          --Items 1 & 2 have been fixed.
          --Item 3 vertical scroll is coming from a fix which was to add scroll bars to grader and other report tables where overflow needs to be visible. However the Advanced Features page seems to be one on its own for a vertical scroll...which is odd, so need to find a fix that.
          --Item 4 needs fixing in BASE theme as NONE of the tables appear to have borders. I don't see the need to add CSS to every theme to style what should be in BASE theme, colours yes, but not border-width and border-style.
          --Item 5 not sure which select box you tried as all the ones I saw have a dark coloured background with white text. There appears to be a problem with Chrome and Linux users. Nadav was having similar problems where the colours were different. I use windows. If you could tell me where the select boxes are I'll fix them.

          Thanks

          Show
          Mary Evans added a comment - @Sam Regarding the display problems you highlighted above --Items 1 & 2 have been fixed. --Item 3 vertical scroll is coming from a fix which was to add scroll bars to grader and other report tables where overflow needs to be visible. However the Advanced Features page seems to be one on its own for a vertical scroll...which is odd, so need to find a fix that. --Item 4 needs fixing in BASE theme as NONE of the tables appear to have borders. I don't see the need to add CSS to every theme to style what should be in BASE theme, colours yes, but not border-width and border-style. --Item 5 not sure which select box you tried as all the ones I saw have a dark coloured background with white text. There appears to be a problem with Chrome and Linux users. Nadav was having similar problems where the colours were different. I use windows. If you could tell me where the select boxes are I'll fix them. Thanks
          Hide
          Sam Hemelryk added a comment -

          Alrighty, I have integrated this now.

          I saw there was a little chatter about backporting this to 2.3, However because it is a relatively significant change I have chosen to integrate to master only (so just 2.4 presently)
          If someone would like this to be considered for backporting then please create an issue for that, although I would like it to stay master only for at least a month to weed out any further issues.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Alrighty, I have integrated this now. I saw there was a little chatter about backporting this to 2.3, However because it is a relatively significant change I have chosen to integrate to master only (so just 2.4 presently) If someone would like this to be considered for backporting then please create an issue for that, although I would like it to stay master only for at least a month to weed out any further issues. Cheers Sam
          Hide
          Mary Evans added a comment -

          Thanks Sam. I'm happy with 2.4

          Show
          Mary Evans added a comment - Thanks Sam. I'm happy with 2.4
          Hide
          Tim Barker added a comment -

          Congratulations, your test passed!

          Show
          Tim Barker added a comment - Congratulations, your test passed!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: