Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32416

Picasa repository does not return path

    Details

    • Testing Instructions:
      Hide

      1. Enable Picasa repository
      2. Add several images in several albums in your Picasa
      3. Access Picasa repository from Filepicker and make sure you can navigate into albums and back to the list of albums

      Show
      1. Enable Picasa repository 2. Add several images in several albums in your Picasa 3. Access Picasa repository from Filepicker and make sure you can navigate into albums and back to the list of albums
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-MDL-32416-master

      Description

      Response from Picasa repository does not return ['path'] and therefore navigation up from the folder is not possible

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Hi Marina,

            My gut instinct was.. surely there must be a way to dot this avoiding this 'caching' instance variable. But I have not had a chance to look into it so I trust you know what you are doing and this is the most pragmatic way forward.

            Show
            poltawski Dan Poltawski added a comment - Hi Marina, My gut instinct was.. surely there must be a way to dot this avoiding this 'caching' instance variable. But I have not had a chance to look into it so I trust you know what you are doing and this is the most pragmatic way forward.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Marina,
            Is this to be backported to the stable branches?

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Marina, Is this to be backported to the stable branches? Cheers Sam
            Hide
            marina Marina Glancy added a comment -

            Hi Sam
            yes

            Show
            marina Marina Glancy added a comment - Hi Sam yes
            Hide
            nebgor Aparup Banerjee added a comment -

            Hi Marina,
            just seeing one small issue here with googleapi.php

            • setting $lastalbumname within get_photo_details() is going to allow havoc once do_photo_search() is ever run. I suggest setting $lastalbumname within get_album_photos() itself.
            Show
            nebgor Aparup Banerjee added a comment - Hi Marina, just seeing one small issue here with googleapi.php setting $lastalbumname within get_photo_details() is going to allow havoc once do_photo_search() is ever run. I suggest setting $lastalbumname within get_album_photos() itself.
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks for the changes Marina. thats been integrated (21,22 and master) and is up for testing.

            note: we simply reworded the comment on get_last_album_name() to say "Returns the name of the album for which get_photo_details was called last time."

            Show
            nebgor Aparup Banerjee added a comment - Thanks for the changes Marina. thats been integrated (21,22 and master) and is up for testing. note: we simply reworded the comment on get_last_album_name() to say "Returns the name of the album for which get_photo_details was called last time."
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success

            Tested in 2.1, 2.2 and master.

            Adding files and navigation works nicely.

            Show
            salvetore Michael de Raadt added a comment - Test result: Success Tested in 2.1, 2.2 and master. Adding files and navigation works nicely.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            UPDATE tracker_issues
               SET status = 'Closed',
                  comment = 'Thanks!'
            WHEN participants = 'Did a gorgeous work'

            This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12