Moodle

ADD custom settings to Anomaly theme

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.5
  • Component/s: Themes
  • Labels:
  • Testing Instructions:
    Hide
    1. Select Anomaly theme via the Theme selector NOT by URL
    2. Go to Site Administration > Appearance > Themes > Theme settings and enable Theme Designer Mode and SAVE settings.
    3. Next go to Site Administration > Appearance > Themes and select Anomaly custom settings page from the list of theme names in the side column.
    4. TEST the Tagline setting by entering a line of text in Tagline text box. You may add <br> tags to the text if the line is very long.
    5. Save settings and go to Home page to see that the text has appeared on the front page only.
    6. TEST the Custom CSS by adding 
      h2.tagline {color: red;}

      to the Custom CSS box.

    7. Save settings and got to Home page and check that the tagline is red and not grey as it was previously.
      #End test.
    Show
    Select Anomaly theme via the Theme selector NOT by URL Go to Site Administration > Appearance > Themes > Theme settings and enable Theme Designer Mode and SAVE settings. Next go to Site Administration > Appearance > Themes and select Anomaly custom settings page from the list of theme names in the side column. TEST the Tagline setting by entering a line of text in Tagline text box. You may add <br> tags to the text if the line is very long. Save settings and go to Home page to see that the text has appeared on the front page only. TEST the Custom CSS by adding h2.tagline {color: red;} to the Custom CSS box. Save settings and got to Home page and check that the tagline is red and not grey as it was previously. #End test.
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_25_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-32420_master
  • Pull Master Diff URL:

Description

As an improvement I would like to see Anomaly with some basic custom settings this would include a 'tagline' MDL-29561 in the page header and also a Custom CSS textarea to add changes to the CSS.

Issue Links

will help resolve

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-25961 Anomaly theme should display a customisable tagline below the header.

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
moodle.com added a comment -

Shifting out of the sprint backlog into the Stable backlog.

Show
moodle.com added a comment - Shifting out of the sprint backlog into the Stable backlog.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

And tested while reviewing both the tag line and the css settings seem to do their work (although I had to purge caches to see the changes).

Also, I've added one extra commit bumping the version, FYI.

Show
Eloy Lafuente (stronk7) added a comment - And tested while reviewing both the tag line and the css settings seem to do their work (although I had to purge caches to see the changes). Also, I've added one extra commit bumping the version, FYI.
Hide
Permalink
Mary Evans added a comment -

@Eloy Lafuente (stronk7) OK...thanks. As for needing to Purge all caches you obviously took no notice of Test Instruction 2. telling you to enable Theme Designer Mode.

Show
Mary Evans added a comment - @ Eloy Lafuente (stronk7) OK...thanks. As for needing to Purge all caches you obviously took no notice of Test Instruction 2. telling you to enable Theme Designer Mode.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

(and won't be revisiting it unless some regression is found)

Thanks and ciao

Show
Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: