Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32434

deprecate database_manager::drop_temp_table()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Database SQL/XMLDB
    • Labels:

      Description

      The problem is that mssql does not support temp tables in database_manager->drop_table()

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              skodak Petr Skoda created issue -
              skodak Petr Skoda made changes -
              Field Original Value New Value
              Fix Version/s 2.3 [ 10657 ]
              Labels triaged
              skodak Petr Skoda made changes -
              Status Open [ 1 ] Development in progress [ 3 ]
              skodak Petr Skoda made changes -
              Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
              Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w16_MDL-32434_m23_droptemp
              Pull Master Branch w16_MDL-32434_m23_droptemp
              Pull from Repository git://github.com/skodak/moodle.git
              Testing Instructions run phpunit tests for all supported databases
              skodak Petr Skoda made changes -
              Link This issue blocks MDL-32400 [ MDL-32400 ]
              Hide
              skodak Petr Skoda added a comment -

              reopening, we discussed this with Eloy adn agreed to deprecate drop_temp_table() completely

              Show
              skodak Petr Skoda added a comment - reopening, we discussed this with Eloy adn agreed to deprecate drop_temp_table() completely
              skodak Petr Skoda made changes -
              Status Waiting for integration review [ 10010 ] Reopened [ 4 ]
              skodak Petr Skoda made changes -
              Status Reopened [ 4 ] Development in progress [ 3 ]
              Hide
              skodak Petr Skoda added a comment -

              drop_temp_table() deprecated

              Show
              skodak Petr Skoda added a comment - drop_temp_table() deprecated
              skodak Petr Skoda made changes -
              Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
              samhemelryk Sam Hemelryk made changes -
              Currently in integration Yes [ 10041 ]
              poltawski Dan Poltawski made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Integrator poltawski
              poltawski Dan Poltawski made changes -
              Summary improve dropping of temp tables deprecate database_manager::drop_temp_table()
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Petr, that has been integrated now

              Show
              poltawski Dan Poltawski added a comment - Thanks Petr, that has been integrated now
              poltawski Dan Poltawski made changes -
              Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
              salvetore Michael de Raadt made changes -
              Tester rajeshtaneja
              rajeshtaneja Rajesh Taneja made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              Hide
              salvetore Michael de Raadt added a comment -

              I'll test this with Oracle shortly.

              Show
              salvetore Michael de Raadt added a comment - I'll test this with Oracle shortly.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Couldn't test this on oracle, requested Michael to test this and will pass this after his comments.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Couldn't test this on oracle, requested Michael to test this and will pass this after his comments.
              Hide
              salvetore Michael de Raadt added a comment -

              Results of the Oracle test included a couple of failures, but I don't think either is relevant to this issue.

              Time: 02:37:41, Memory: 143.75Mb
               
              There were 2 failures:
               
              1) dml_testcase::test_sql_concat
              ANSI behaviour: Concatenating NULL must return NULL - But in Oracle :-(. [%s]
              Failed asserting that '123.45test' is null.
               
              D:\xampp\htdocs\moodle_testing_oracle\lib\dml\tests\dml_test.php:3586
              D:\xampp\php\phpunit:46
               
              2) moodlesimplepie_testcase::test_getfeed
              Failed to load the sample RSS file. Please check your proxy settings in Moodle.
              %s
              Failed asserting that 'cURL Error: Operation timed out after 2012 milliseconds w
              ith 30241 out of 32188 bytes received' is null.
               
              D:\xampp\htdocs\moodle_testing_oracle\lib\tests\rsslib_test.php:56
              D:\xampp\htdocs\moodle_testing_oracle\lib\phpunit\lib.php:1058
              D:\xampp\php\phpunit:46
               
              FAILURES!
              Tests: 1070, Assertions: 20535, Failures: 2.

              Show
              salvetore Michael de Raadt added a comment - Results of the Oracle test included a couple of failures, but I don't think either is relevant to this issue. Time: 02:37:41, Memory: 143.75Mb   There were 2 failures:   1) dml_testcase::test_sql_concat ANSI behaviour: Concatenating NULL must return NULL - But in Oracle :-(. [%s] Failed asserting that '123.45test' is null.   D:\xampp\htdocs\moodle_testing_oracle\lib\dml\tests\dml_test.php:3586 D:\xampp\php\phpunit:46   2) moodlesimplepie_testcase::test_getfeed Failed to load the sample RSS file. Please check your proxy settings in Moodle. %s Failed asserting that 'cURL Error: Operation timed out after 2012 milliseconds w ith 30241 out of 32188 bytes received' is null.   D:\xampp\htdocs\moodle_testing_oracle\lib\tests\rsslib_test.php:56 D:\xampp\htdocs\moodle_testing_oracle\lib\phpunit\lib.php:1058 D:\xampp\php\phpunit:46   FAILURES! Tests: 1070, Assertions: 20535, Failures: 2.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks Michael,

              Reported failures doesn't seem to be related to drop_temp_table changes, hence passing this test.

              Thanks everyone for working on this

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks Michael, Reported failures doesn't seem to be related to drop_temp_table changes, hence passing this test. Thanks everyone for working on this
              rajeshtaneja Rajesh Taneja made changes -
              Status Testing in progress [ 10011 ] Tested [ 10006 ]
              Hide
              poltawski Dan Poltawski added a comment -

              Bonza mate!

              Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.

              Hooroo

              Show
              poltawski Dan Poltawski added a comment - Bonza mate! Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby. Hooroo
              poltawski Dan Poltawski made changes -
              Status Tested [ 10006 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]
              Currently in integration Yes [ 10041 ]
              poltawski Dan Poltawski made changes -
              Integration date 19/Apr/12

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12