Moodle
  1. Moodle
  2. MDL-32434

deprecate database_manager::drop_temp_table()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Database SQL/XMLDB
    • Labels:
    • Rank:
      39308

      Description

      The problem is that mssql does not support temp tables in database_manager->drop_table()

        Issue Links

          Activity

          Petr Škoda created issue -
          Petr Škoda made changes -
          Field Original Value New Value
          Fix Version/s 2.3 [ 10657 ]
          Labels triaged
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w16_MDL-32434_m23_droptemp
          Pull Master Branch w16_MDL-32434_m23_droptemp
          Pull from Repository git://github.com/skodak/moodle.git
          Testing Instructions run phpunit tests for all supported databases
          Petr Škoda made changes -
          Link This issue blocks MDL-32400 [ MDL-32400 ]
          Hide
          Petr Škoda added a comment -

          reopening, we discussed this with Eloy adn agreed to deprecate drop_temp_table() completely

          Show
          Petr Škoda added a comment - reopening, we discussed this with Eloy adn agreed to deprecate drop_temp_table() completely
          Petr Škoda made changes -
          Status Waiting for integration review [ 10010 ] Reopened [ 4 ]
          Petr Škoda made changes -
          Status Reopened [ 4 ] Development in progress [ 3 ]
          Hide
          Petr Škoda added a comment -

          drop_temp_table() deprecated

          Show
          Petr Škoda added a comment - drop_temp_table() deprecated
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Dan Poltawski made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator poltawski
          Dan Poltawski made changes -
          Summary improve dropping of temp tables deprecate database_manager::drop_temp_table()
          Hide
          Dan Poltawski added a comment -

          Thanks Petr, that has been integrated now

          Show
          Dan Poltawski added a comment - Thanks Petr, that has been integrated now
          Dan Poltawski made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Michael de Raadt made changes -
          Tester rajeshtaneja
          Rajesh Taneja made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Michael de Raadt added a comment -

          I'll test this with Oracle shortly.

          Show
          Michael de Raadt added a comment - I'll test this with Oracle shortly.
          Hide
          Rajesh Taneja added a comment -

          Couldn't test this on oracle, requested Michael to test this and will pass this after his comments.

          Show
          Rajesh Taneja added a comment - Couldn't test this on oracle, requested Michael to test this and will pass this after his comments.
          Hide
          Michael de Raadt added a comment -

          Results of the Oracle test included a couple of failures, but I don't think either is relevant to this issue.

          Time: 02:37:41, Memory: 143.75Mb
          
          There were 2 failures:
          
          1) dml_testcase::test_sql_concat
          ANSI behaviour: Concatenating NULL must return NULL - But in Oracle :-(. [%s]
          Failed asserting that '123.45test' is null.
          
          D:\xampp\htdocs\moodle_testing_oracle\lib\dml\tests\dml_test.php:3586
          D:\xampp\php\phpunit:46
          
          2) moodlesimplepie_testcase::test_getfeed
          Failed to load the sample RSS file. Please check your proxy settings in Moodle.
          %s
          Failed asserting that 'cURL Error: Operation timed out after 2012 milliseconds w
          ith 30241 out of 32188 bytes received' is null.
          
          D:\xampp\htdocs\moodle_testing_oracle\lib\tests\rsslib_test.php:56
          D:\xampp\htdocs\moodle_testing_oracle\lib\phpunit\lib.php:1058
          D:\xampp\php\phpunit:46
          
          FAILURES!
          Tests: 1070, Assertions: 20535, Failures: 2.
          
          Show
          Michael de Raadt added a comment - Results of the Oracle test included a couple of failures, but I don't think either is relevant to this issue. Time: 02:37:41, Memory: 143.75Mb There were 2 failures: 1) dml_testcase::test_sql_concat ANSI behaviour: Concatenating NULL must return NULL - But in Oracle :-(. [%s] Failed asserting that '123.45test' is null. D:\xampp\htdocs\moodle_testing_oracle\lib\dml\tests\dml_test.php:3586 D:\xampp\php\phpunit:46 2) moodlesimplepie_testcase::test_getfeed Failed to load the sample RSS file. Please check your proxy settings in Moodle. %s Failed asserting that 'cURL Error: Operation timed out after 2012 milliseconds w ith 30241 out of 32188 bytes received' is null. D:\xampp\htdocs\moodle_testing_oracle\lib\tests\rsslib_test.php:56 D:\xampp\htdocs\moodle_testing_oracle\lib\phpunit\lib.php:1058 D:\xampp\php\phpunit:46 FAILURES! Tests: 1070, Assertions: 20535, Failures: 2.
          Hide
          Rajesh Taneja added a comment -

          Thanks Michael,

          Reported failures doesn't seem to be related to drop_temp_table changes, hence passing this test.

          Thanks everyone for working on this

          Show
          Rajesh Taneja added a comment - Thanks Michael, Reported failures doesn't seem to be related to drop_temp_table changes, hence passing this test. Thanks everyone for working on this
          Rajesh Taneja made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Dan Poltawski added a comment -

          Bonza mate!

          Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.

          Hooroo

          Show
          Dan Poltawski added a comment - Bonza mate! Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby. Hooroo
          Dan Poltawski made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Dan Poltawski made changes -
          Integration date 19/Apr/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: