Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32448

import of YUI 3.5.0 into master

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:

      Gliffy Diagrams

        Attachments

          Issue Links

            Activity

            skodak Petr Skoda created issue -
            skodak Petr Skoda made changes -
            Field Original Value New Value
            Fix Version/s DEV backlog [ 10464 ]
            Labels triaged
            skodak Petr Skoda made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            skodak Petr Skoda made changes -
            Summary consider importing of YUI 3.5.0 into master import of YUI 3.5.0 into master
            Hide
            skodak Petr Skoda added a comment -

            I think this should be integrated soon so that we have enough time to find all problems and resolve them

            Show
            skodak Petr Skoda added a comment - I think this should be integrated soon so that we have enough time to find all problems and resolve them
            skodak Petr Skoda made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w16_MDL-32448_m23_yui350
            Pull Master Branch w16_MDL-32448_m23_yui350
            Pull from Repository git://github.com/skodak/moodle.git
            Fix Version/s 2.3 [ 10657 ]
            Fix Version/s DEV backlog [ 10464 ]
            Testing Instructions try as much UI that uses YUI as possible, report problems as new issues
            skodak Petr Skoda made changes -
            Priority Minor [ 4 ] Critical [ 2 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator stronk7
            Currently in integration Yes [ 10041 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Surely it would be interesting to have one detailed list of YUI artifacts to be tested in core, so each time we update the library, everything can be checked.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! Surely it would be interesting to have one detailed list of YUI artifacts to be tested in core, so each time we update the library, everything can be checked.
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            salvetore Michael de Raadt made changes -
            Peer reviewer andyjdavis
            salvetore Michael de Raadt made changes -
            Tester rwijaya
            salvetore Michael de Raadt made changes -
            Tester rwijaya timb
            salvetore Michael de Raadt made changes -
            Peer reviewer andyjdavis
            timb Tim Barker made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            timb Tim Barker added a comment - - edited

            Ran the current Selenium tests against this to check for regressions. Coverage includes multiple yui elements. All tests passed!

            Show
            timb Tim Barker added a comment - - edited Ran the current Selenium tests against this to check for regressions. Coverage includes multiple yui elements. All tests passed!
            Hide
            timb Tim Barker added a comment -

            This type of testing is very suited to the Selenium test automation suite.

            I agree with Eloy, to plan a good suite of regression tests I will need a list of UI elements. Without this I cannot build a coverage map or plan yui targeted regression testing properly. If we did this, the regression testing of these would be very easy to set up and manage and could be run via Jenkins by whoever, whenever it was required.

            Show
            timb Tim Barker added a comment - This type of testing is very suited to the Selenium test automation suite. I agree with Eloy, to plan a good suite of regression tests I will need a list of UI elements. Without this I cannot build a coverage map or plan yui targeted regression testing properly. If we did this, the regression testing of these would be very easy to set up and manage and could be run via Jenkins by whoever, whenever it was required.
            Hide
            timb Tim Barker added a comment -

            I performed the following regression testing:
            Run Selenium test suite.
            Performed additional ad-hoc exploratory testing.
            No problems noticed so far.

            Show
            timb Tim Barker added a comment - I performed the following regression testing: Run Selenium test suite. Performed additional ad-hoc exploratory testing. No problems noticed so far.
            timb Tim Barker made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            poltawski Dan Poltawski added a comment -

            Bonza mate!

            Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby.

            Hooroo

            Show
            poltawski Dan Poltawski added a comment - Bonza mate! Your changes have made it into the Moodle release! Its time to celebrate! Put a shrimp on the barbie and grab a stubby. Hooroo
            poltawski Dan Poltawski made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            poltawski Dan Poltawski made changes -
            Integration date 19/Apr/12
            skodak Petr Skoda made changes -
            Link This issue has been marked as being related by MDL-32675 [ MDL-32675 ]
            dougiamas Martin Dougiamas made changes -
            Link This issue has been marked as being related by MDL-32843 [ MDL-32843 ]
            Hide
            dobedobedoh Andrew Nicols added a comment -

            This has caused a regression on master - git bisect points to this commit. Will verify and open a new issue.

            Show
            dobedobedoh Andrew Nicols added a comment - This has caused a regression on master - git bisect points to this commit. Will verify and open a new issue.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12