Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31167 PHP strict META
  3. MDL-32454

MNet Peers moodleform validators fail strict standards

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.1.6, 2.2.3
    • 2.1.5, 2.2.2, 2.3
    • MNet
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MDL-32454-master-1
    • Hide

      These changes shouldn't have any effect on functionality:

      • The new validation parameter shouldn't have any effect
      • It's not possible to assign a function result by reference anyway so this should just get rid of the warning
      • The missing $CFG settings shouldn't have any noticable effect as defaults are provided

      One way to test this (I confirmed some of the warnings that way) is to:

      1) Enable DEBUG_DEVELOPER
      2) Enable MNET in the site and visit all the mnet admin pages (admin -> networking) and the tabs and links within them.
      3) TEST: Confirm no PHP NOTICE/WARN/STRICT message is shown.

      Show
      These changes shouldn't have any effect on functionality: The new validation parameter shouldn't have any effect It's not possible to assign a function result by reference anyway so this should just get rid of the warning The missing $CFG settings shouldn't have any noticable effect as defaults are provided One way to test this (I confirmed some of the warnings that way) is to: 1) Enable DEBUG_DEVELOPER 2) Enable MNET in the site and visit all the mnet admin pages (admin -> networking) and the tabs and links within them. 3) TEST: Confirm no PHP NOTICE/WARN/STRICT message is shown.

      With the new strict standards on, navigating to the mnet peers page gives:

      Strict standards: Declaration of mnet_simple_host_form::validation() should be compatible with that of moodleform::validation() in /home/nicols/git/software/moodle/admin/mnet/peer_forms.php on line 35 Call Stack: 0.0005 797360 1. {main}() /home/nicols/git/software/moodle/admin/mnet/peers.php:0 0.1328 35104576 2. require_once('/home/nicols/git/software/moodle/admin/mnet/peer_forms.php') /home/nicols/git/software/moodle/admin/mnet/peers.php:33 Strict standards: Declaration of mnet_review_host_form::validation() should be compatible with that of moodleform::validation() in /home/nicols/git/software/moodle/admin/mnet/peer_forms.php on line 73 Call Stack: 0.0005 797360 1. {main}() /home/nicols/git/software/moodle/admin/mnet/peers.php:0 0.1328 35104576 2. require_once('/home/nicols/git/software/moodle/admin/mnet/peer_forms.php') /home/nicols/git/software/moodle/admin/mnet/peers.php:33

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Dan Poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Andrew Davis Andrew Davis
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.