Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Duplicate
-
Affects Version/s: 2.3
-
Fix Version/s: None
-
Component/s: Database activity module
-
Labels:None
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-32456_database_dndupload -
Pull Master Diff URL:
Description
The database activity module uses a non-standard filepicker element for uploading pictures.
This means it hasn't picked up the new drag and drop upload code.
I have not investigated enough to work out why it needs to use different code (and whether this it still needs to use separate code).
Gliffy Diagrams
Issue Links
- will be (partly) resolved by
-
MDL-7660
Unable to delete database activity entry attachment
-
- Closed
-
Activity
That's b/c the module's file and picture fields and respective js have not been updated to include the dndupload enhancement. 
This patch should enable drag and drop upload to mod_data fields
Thanks for the patch Davo,
As far as we can tell, the patch has fixed the problem. We expect that the number of empty entries will now drop, but we noticed that the problem with empty entries (if the database has only a file upload field) breaking the list view still exists.
Hi Davo,
We discovered that while the drag and drop upload now works in the databases of our 2.3.3 installation, the Choose a file button, for the traditional upload via the filepicker does not work anymore. This stops IE9 (and older) users from using the database.
Thanks for the update - I'll try again locally and see if I can fix it.
We tried replacing in data.js line 77
M.data_filepicker.instances[client_id].show();
with
M.core_filepicker.instances[client_id].show();
This seems to fix the problem of the Choose a file button not working, but it will need more testing to make sure.
Yes, that would be the correct fix - if you look at line 153, that contains the correct code.
I've updated the patch.
Hi Davo,
Adrians recent patch (master only) MDL-7660 changes the file picker for the file manager which allows deleting of files and drag and drop. This is a master only change as it is an improvement rather than a bug fix. If we did decide to backport to stable branches it would probably be better to backport that issue than to have a different patch for master/stables.
Thanks for working on this - but I think we should close this issue as a duplicate.
Regards, Damyon
Closing as duplicate, as suggested above.
Hi, It may all be very well that this database bug will be fixed in version 2.5, but in the meantime, we have a database that does not work properly. Can't this temporary fix be maintained until the final solution arrives?
I can confirm that this issue exists in Moodle 2.3.2. Drag and rop does not work in the database activity module and it appears to be causing empty entries that break the list view.