Moodle
  1. Moodle
  2. MDL-32459

MNet Peer Services text confusing

    Details

    • Testing Instructions:
      Hide
      • From Site administration, choose Advanced Features
        • Enable Networking
      • Navigate to Site administration -> Networking -> Manage Peers
      • Select 'All Hosts'
      • Select the 'Services' tab
        • Bullet points detailing dependency information for 'Remote enrolment service' should be in the same order as the tickboxes
      Show
      From Site administration, choose Advanced Features Enable Networking Navigate to Site administration -> Networking -> Manage Peers Select 'All Hosts' Select the 'Services' tab Bullet points detailing dependency information for 'Remote enrolment service' should be in the same order as the tickboxes
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32459-master-1
    • Rank:
      39342

      Description

      I noticed when testing some MNet issues that the text for Remote Enrolment services of a peer can be really confusing because the publish/subscribe dependency information lists Identity Provider and Service Provider in the text in a different order to the relevant sections.

        Activity

        Hide
        Andrew Nicols added a comment -

        This should cherry-pick cleanly to stable branches

        Show
        Andrew Nicols added a comment - This should cherry-pick cleanly to stable branches
        Hide
        Dan Poltawski added a comment -

        Assigning to Helen to peer review

        Show
        Dan Poltawski added a comment - Assigning to Helen to peer review
        Hide
        Helen Foster added a comment -

        Looks good to me. Thanks Andrew

        Show
        Helen Foster added a comment - Looks good to me. Thanks Andrew
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Hi Andrew,

        Thanks that has been integrated now.

        Unfortunately I noticed after i'd pushed that you didn't include the component in the commit message. Please can you ensure you mention component as it helps when people are looking through the commit logs to see which areas are affected.

        (Its not an exact science of components, mostly to help the reader so use common sense - in this case 'lang' or 'mnet' would be fine.)

        Show
        Dan Poltawski added a comment - Hi Andrew, Thanks that has been integrated now. Unfortunately I noticed after i'd pushed that you didn't include the component in the commit message. Please can you ensure you mention component as it helps when people are looking through the commit logs to see which areas are affected. (Its not an exact science of components, mostly to help the reader so use common sense - in this case 'lang' or 'mnet' would be fine.)
        Hide
        Jason Fowler added a comment -

        Looks good to me

        Show
        Jason Fowler added a comment - Looks good to me
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: