Moodle
  1. Moodle
  2. MDL-32477

allow cloning of core permissions in plugins

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1, 2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Roles / Access
    • Labels:
    • Rank:
      39366

      Description

      at present you can clone in core or in one plugin only, for upgrades of addinstance cap we need to clone from core-->module

      and update: http://docs.moodle.org/dev/Access_API#How_to_define_new_capabilities_in_plugins

        Activity

        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Hi Petr,

        Do you think this is necessary to put on the stable branches?

        Show
        Dan Poltawski added a comment - Hi Petr, Do you think this is necessary to put on the stable branches?
        Hide
        Petr Škoda added a comment -

        The problem with stable is that ppl often install newer contrib versions in older moodle versions - in general that is not discouraged and should work, but in case of new addinstance capability they would loose the migration of custom roles if this issue was not backported.

        Show
        Petr Škoda added a comment - The problem with stable is that ppl often install newer contrib versions in older moodle versions - in general that is not discouraged and should work, but in case of new addinstance capability they would loose the migration of custom roles if this issue was not backported.
        Hide
        Dan Poltawski added a comment -

        Hmm, for some reason this test seems to run very slow for me

        Show
        Dan Poltawski added a comment - Hmm, for some reason this test seems to run very slow for me
        Hide
        Dan Poltawski added a comment -

        Thanks, this has been integrated now.

        Show
        Dan Poltawski added a comment - Thanks, this has been integrated now.
        Hide
        Michael de Raadt added a comment -

        I'm going to run the phpunit tests in a couple of other issues. I can let you know how that goes.

        Show
        Michael de Raadt added a comment - I'm going to run the phpunit tests in a couple of other issues. I can let you know how that goes.
        Hide
        Adrian Greeve added a comment -

        I ran the phpunit tests in master and then tested installing ouwiki in 2.1 and 2.2. Besides the module missing a whole bunch of language strings, everything else worked well.
        Thanks.

        Show
        Adrian Greeve added a comment - I ran the phpunit tests in master and then tested installing ouwiki in 2.1 and 2.2. Besides the module missing a whole bunch of language strings, everything else worked well. Thanks.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: