The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Hi Petr,

Do you think this is necessary to put on the stable branches?

The problem with stable is that ppl often install newer contrib versions in older moodle versions - in general that is not discouraged and should work, but in case of new addinstance capability they would loose the migration of custom roles if this issue was not backported.

Hmm, for some reason this test seems to run very slow for me

Thanks, this has been integrated now.

I'm going to run the phpunit tests in a couple of other issues. I can let you know how that goes.

I ran the phpunit tests in master and then tested installing ouwiki in 2.1 and 2.2. Besides the module missing a whole bunch of language strings, everything else worked well.
Thanks.

This has been near becoming rejected, because it's not the best code you are able to produce.

But, luckily, at the end, it has landed and has been spread to all repos out there.

Many thanks and, don't forget it, keep improving your skills, you can!

Closing, ciao