Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32479

RTL Theme fixes for Moodle 2 (theme/base)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.2.2
    • 2.3
    • Themes
    • MOODLE_22_STABLE
    • MOODLE_23_STABLE
    • MDL-32479_master
    • Hide
      1. Select BASE theme
      2. Switch to RTL language
      3. Turn on editing and check that block actions are aligned nicely.
      4. Check the layout of a file picker element anywhere
      5. Check the layout of a mform with a fieldset element (a grouping)
      6. Check the alignment of block headings on my/index.php
      7. Add a combo list to the front page and check its alignment
      Show
      Select BASE theme Switch to RTL language Turn on editing and check that block actions are aligned nicely. Check the layout of a file picker element anywhere Check the layout of a mform with a fieldset element (a grouping) Check the alignment of block headings on my/index.php Add a combo list to the front page and check its alignment

    Description

      Support for blocks columns switch when in rtl mode:
      theme/base/layout/frontpage.php
      theme/base/layout/general.php

      Right align course completion checkbox to the right side of the activities and resources, when in RTL mode
      theme/base/style/course.css

      Right align DOCK bar, when in RTL mode
      theme/base/style/dock.css

      First-name and Last-name Initials (filter) bar (on every users list) letters spacing (usability issue, NOT RTL issue)
      theme/base/style/core.css

      I'll be committing more fixes in the comments to this issue since they are relevant to this patch but are more specific to the LESSON and GLOSSARY modules. (I made the changes in the respective Activity style.css file, but they could be added to the theme/base/styles as well)

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33830 Filemanager tree view show dotted line in other direction

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35790 Drag and Drop of Blocks does not function when using Standard theme, in RTL mode

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-33931 Fix the reverted 15% indent on form submit buttons in canvas themes and base

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32821 META: RTL Theme fixes for Moodle 2 (Take 4)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32821 META: RTL Theme fixes for Moodle 2 (Take 4)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30337 RTL Theme fixes for Moodle 2.x.x

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              lazydaisy Mary Evans
              nadavkav Nadav Kavalerchik
              Nadav Kavalerchik Nadav Kavalerchik
              Sam Hemelryk Sam Hemelryk
              Adrian Greeve Adrian Greeve
              Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                25/Jun/12