Moodle
  1. Moodle
  2. MDL-32480

IMS content packages with external links don't display

    Details

    • Rank:
      39370

      Description

      IMS Content Packages can either incorporate resources as files within the Content Package, or just provide links to external repositories (http://www.imsglobal.org/content/packaging/cpv1p2pd2/imscp_primerv1p2pd2.html#Xaa1747408).

      In Moodle 2, IMS Content Packages of the latter kind don't display the remote pages (i.e. try to display them as if they were local pages).

        Activity

        Hide
        Nicolas Dunand added a comment -

        It seems the XML parser handles this correctly but later the part of the code building the HTML markup assumes the resources are all local links.

        Proposed fix attached.

        Show
        Nicolas Dunand added a comment - It seems the XML parser handles this correctly but later the part of the code building the HTML markup assumes the resources are all local links. Proposed fix attached.
        Hide
        Nicolas Dunand added a comment -

        Hi,
        Sorry if this is not the right way to proceed, but I have a fix for this issue and would like to have it reviewed.

        Show
        Nicolas Dunand added a comment - Hi, Sorry if this is not the right way to proceed, but I have a fix for this issue and would like to have it reviewed.
        Hide
        Petr Škoda added a comment -

        Hello, I suppose it could look for https links too, there is a also a minor whitespace issue before the else keyword.

        otherwise my +1

        Show
        Petr Škoda added a comment - Hello, I suppose it could look for https links too, there is a also a minor whitespace issue before the else keyword. otherwise my +1
        Hide
        Petr Škoda added a comment -

        hello, could you please put the patch into some git repository in a branch on top of current master?

        Show
        Petr Škoda added a comment - hello, could you please put the patch into some git repository in a branch on top of current master?
        Hide
        Nicolas Dunand added a comment -
        Show
        Nicolas Dunand added a comment - Hello Petr, Here : https://github.com/ndunand/moodle/tree/MDL-32480
        Hide
        Petr Škoda added a comment -

        Thanks Nicolas for the branch, I have tweaked the commit message a bit (see http://docs.moodle.org/dev/Commit_cheat_sheet) and added one more commit that adds https:// support too.

        Could you please attach some small test file here? I would have a lot during testing...

        Show
        Petr Škoda added a comment - Thanks Nicolas for the branch, I have tweaked the commit message a bit (see http://docs.moodle.org/dev/Commit_cheat_sheet ) and added one more commit that adds https:// support too. Could you please attach some small test file here? I would have a lot during testing...
        Hide
        Nicolas Dunand added a comment -

        A small IMS content package to test, containing links to an external Web site. Content is from a geology course, but I'm afraid it's in French.

        Show
        Nicolas Dunand added a comment - A small IMS content package to test, containing links to an external Web site. Content is from a geology course, but I'm afraid it's in French.
        Hide
        Petr Škoda added a comment -

        thanks!

        Show
        Petr Škoda added a comment - thanks!
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks guys! this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks guys! this has been integrated now.
        Hide
        Rajesh Taneja added a comment -

        Thanks for fixing this Petr,

        I tried it with attached IMS package and I can see external contents being displayed.

        Show
        Rajesh Taneja added a comment - Thanks for fixing this Petr, I tried it with attached IMS package and I can see external contents being displayed.
        Hide
        Marina Glancy added a comment -

        Thanks for your awesome work! This has now become a part of Moodle.

        Closing as fixed!

        Show
        Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: