Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      Support for blocks columns switch when in rtl mode:
      theme/afterburner/layout/default.php

      Right align DOCK bar, when in RTL mode
      theme/afterburner/style/afterburner_dock.css

      Right align header's custom menu, when in RTL mode
      theme/afterburner/style/rtl.css
      added theme/afterburner/pix/menu/nav-arrow-left.png

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Mary Evans added a comment - - edited

            Hi Nadav,
            I'm not sure if you are doing this right or not. As this is totally different than I would do...or how I have read how to do commits.

            First I would create a local branch MDL-32481_master based on my local copy of origin/master
            Then in this branch MDL-32481_master I would do all my CSS changes. When I have finished I check status to find all the stylesheets I have corrected, and then do
            git commit -a
            add my comment for the commit something like: MDL-32481 theme_afterburner: RTL fix for switch columns
            After which I would do...
            git push origin MDL-32481_master

            This then is the branch that is added in the information for example:

            Pull master branch: MDL-32481_master
            Pull master Diff URL: https://github.com/nadavkav/moodle/compare/master...MDL-32481_master
            

            Show
            Mary Evans added a comment - - edited Hi Nadav, I'm not sure if you are doing this right or not. As this is totally different than I would do...or how I have read how to do commits. First I would create a local branch MDL-32481 _master based on my local copy of origin/master Then in this branch MDL-32481 _master I would do all my CSS changes. When I have finished I check status to find all the stylesheets I have corrected, and then do git commit -a add my comment for the commit something like: MDL-32481 theme_afterburner: RTL fix for switch columns After which I would do... git push origin MDL-32481 _master This then is the branch that is added in the information for example: Pull master branch: MDL-32481_master Pull master Diff URL: https://github.com/nadavkav/moodle/compare/master...MDL-32481_master
            Hide
            Nadav Kavalerchik added a comment -

            I am familiar with your commit suggestions.

            It is just that I am building it all up to the point where I have all the themes with the RTL fixes on the same branch (:theme_rtl), Then I will have the proper pull diff.

            What you actually see (get) when you currently click the "pull diff url" is the commit itself.
            When I am all done with all the commits for all the different themes, I will make a new MDL with the proper "pull master diff url" so all the themes could be pulled in one go.

            I wanted to have the opportunity for us to have different MDL for each theme, to discuss the various changes.
            In case anyone suggest new CSS changes or rejects some.

            As you pointed out and... since no Moodle HQ developer has joined the conversation, I am not sure if this is the most useful way to commit the changes.

            Show
            Nadav Kavalerchik added a comment - I am familiar with your commit suggestions. It is just that I am building it all up to the point where I have all the themes with the RTL fixes on the same branch (:theme_rtl), Then I will have the proper pull diff. What you actually see (get) when you currently click the "pull diff url" is the commit itself. When I am all done with all the commits for all the different themes, I will make a new MDL with the proper "pull master diff url" so all the themes could be pulled in one go. I wanted to have the opportunity for us to have different MDL for each theme, to discuss the various changes. In case anyone suggest new CSS changes or rejects some. As you pointed out and... since no Moodle HQ developer has joined the conversation, I am not sure if this is the most useful way to commit the changes.
            Hide
            Mary Evans added a comment -

            I realised this after I had written my last comment...you said as much earlier in the discussion in the other thread.

            Show
            Mary Evans added a comment - I realised this after I had written my last comment...you said as much earlier in the discussion in the other thread.
            Hide
            Mary Evans added a comment - - edited

            You can invite people like Martin, & Sam to watch your progress. If it interests them they will comment. What you are doing is a good thing, and we know it works.

            At the end of the day they have to make Moodle work for everyone, and as we all use different languages the need to add these differences to Moodle is essential as thy progress towards Moodle 2.4.

            So just add a few people as watchers.

            Cheers
            Mary

            Show
            Mary Evans added a comment - - edited You can invite people like Martin, & Sam to watch your progress. If it interests them they will comment. What you are doing is a good thing, and we know it works. At the end of the day they have to make Moodle work for everyone, and as we all use different languages the need to add these differences to Moodle is essential as thy progress towards Moodle 2.4. So just add a few people as watchers. Cheers Mary
            Hide
            Nadav Kavalerchik added a comment -

            @Mary
            You are right! Thank you for the advise, I will

            @Patrick Malley
            I have added you as watcher for this issue, to ask you to have a look at the "switch block column" php patch code, especially, and to make sure it is the right way to do it for the benefit of both LTR and RTL users.
            (Since i am using the same hack on all themes)

            Show
            Nadav Kavalerchik added a comment - @Mary You are right! Thank you for the advise, I will @Patrick Malley I have added you as watcher for this issue, to ask you to have a look at the "switch block column" php patch code, especially, and to make sure it is the right way to do it for the benefit of both LTR and RTL users. (Since i am using the same hack on all themes)
            Hide
            Mary Evans added a comment - - edited

            Hi Nadav,

            I have a feeling Patrick is very busy and may not have time to check things out here. However, since I created this theme, I know it back to front, and I've checked and tested the fixes you added. I have also added a few more which work fine.
            The dock was the hardest to fix as it is more styled than the plain and simple one used in Base-RTL. There was also another image for the menu, which I have added to my working copy.

            So I am wondering if it might be better if I take over this theme and submit it now, that way there would be a theme which is usable with switching columns and dock functionality for RTL, then you could get some feedback.

            There's a good chance too of getting this into Moodle 2.2 and Moodle 2.1 as long as there are no conflicts.

            What do you think?

            Show
            Mary Evans added a comment - - edited Hi Nadav, I have a feeling Patrick is very busy and may not have time to check things out here. However, since I created this theme, I know it back to front, and I've checked and tested the fixes you added. I have also added a few more which work fine. The dock was the hardest to fix as it is more styled than the plain and simple one used in Base-RTL. There was also another image for the menu, which I have added to my working copy. So I am wondering if it might be better if I take over this theme and submit it now, that way there would be a theme which is usable with switching columns and dock functionality for RTL, then you could get some feedback. There's a good chance too of getting this into Moodle 2.2 and Moodle 2.1 as long as there are no conflicts. What do you think?
            Show
            Nadav Kavalerchik added a comment - more updates: https://github.com/nadavkav/moodle/commit/fa505afa1134b2df768d98bd3df5876297f12a0c
            Hide
            Mary Evans added a comment -

            Just added this now as a sub-task of MDL-32821

            Show
            Mary Evans added a comment - Just added this now as a sub-task of MDL-32821
            Hide
            Mary Evans added a comment -

            Providing that MDL-32412 is integrated in the next pull the RTL theme fixes for Afterburner theme will be included too. This issue can then be closed.

            Show
            Mary Evans added a comment - Providing that MDL-32412 is integrated in the next pull the RTL theme fixes for Afterburner theme will be included too. This issue can then be closed.
            Hide
            Nadav Kavalerchik added a comment -

            Fixed on latest 2.6dev (18/8/2013). And was probably fixed a while ago
            So, closing...1...2.....3

            Thanks you Mary Evans.

            Show
            Nadav Kavalerchik added a comment - Fixed on latest 2.6dev (18/8/2013). And was probably fixed a while ago So, closing...1...2.....3 Thanks you Mary Evans .

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: