Moodle
  1. Moodle
  2. MDL-32484

Wiki tabs don't display "Administration" tab from within "Files" tab

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.3
    • Fix Version/s: None
    • Component/s: Wiki (2.x)
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Enter any wiki as an administrator and click the "Files" tab: the "Administration" tab disappears.

      Show
      Enter any wiki as an administrator and click the "Files" tab: the "Administration" tab disappears.
    • Workaround:
      Hide

      Use attached diff file.

      Show
      Use attached diff file.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      When displaying a wiki as a teacher (or higher role), visible tabs are:
      View, Edit, Comments, History, Map, Files, Administration

      After clicking on the "Files" tab, the "Administration" tab is not displayed anymore. On all other tabbed pages the "Administration" tab is still visible.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Nicolas Dunand added a comment -

            It seems tabs are hard-coded in files.php, whereas they're dynamically rendered in a consistent manner in all other tabbed pages.

            One solution would be to create a new page_wiki_files (extending page_wiki), but I don't want to go that far yet.

            Therefore my proposed fix simply checks for the "mod/wiki:managefiles" capability and adds the "Administration" tab accordingly.

            Show
            Nicolas Dunand added a comment - It seems tabs are hard-coded in files.php, whereas they're dynamically rendered in a consistent manner in all other tabbed pages. One solution would be to create a new page_wiki_files (extending page_wiki), but I don't want to go that far yet. Therefore my proposed fix simply checks for the "mod/wiki:managefiles" capability and adds the "Administration" tab accordingly.
            Hide
            Adrian Greeve added a comment -

            This patch works, but I like the solution in MDL-31816 better as it follows the same logic as the other pages in wiki.

            Show
            Adrian Greeve added a comment - This patch works, but I like the solution in MDL-31816 better as it follows the same logic as the other pages in wiki.
            Hide
            Michael de Raadt added a comment -

            Thanks for reporting this issue.

            We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

            If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

            Michael d.

            TW9vZGxlDQo=

            Show
            Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
            Hide
            Nicolas Dunand added a comment -

            Thanks Michael. I confirm this is fixed in Moodle 2.5.1 at least.

            Show
            Nicolas Dunand added a comment - Thanks Michael. I confirm this is fixed in Moodle 2.5.1 at least.
            Hide
            Charles Fulton added a comment -

            This was resolved by MDL-38309 and can be closed.

            Show
            Charles Fulton added a comment - This was resolved by MDL-38309 and can be closed.
            Hide
            Marina Glancy added a comment -

            Thanks Charles, closing as fixed

            Show
            Marina Glancy added a comment - Thanks Charles, closing as fixed

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: