Moodle
  1. Moodle
  2. MDL-32490

Offline assignments should not show lateness information

    Details

    • Testing Instructions:
      Hide

      NOTE: Don't forget to test this in all branches (21, 22 & master).

      In a course with some students enrolled, do the following as teacher or administrator.

      A)

      • Create an offline assignment, setting the due date to yesterday.
        VERIFY: "Prevent late submissions" box is NOT shown below the "Due date" field.
      • Go to the grading screen.
      • Enter some student grades and submit.
        VERIFY: Students' grades appear in the list but are NOT marked in red, no lateness information shown in the "Last modified (submission)" column.

      B)

      • Create an online text assignment, setting the due date to yesterday.
        VERIFY: "Prevent late submissions" box is shown below the "Due date" field.
      • Log in as as a student and make a submission.
      • Log in as the teacher and go to the grading screen.
        VERIFY: The student's submission is marked in red, with lateness information shown in the "Last modified (submission)" column..
      Show
      NOTE: Don't forget to test this in all branches (21, 22 & master). In a course with some students enrolled, do the following as teacher or administrator. A) Create an offline assignment, setting the due date to yesterday. VERIFY: "Prevent late submissions" box is NOT shown below the "Due date" field. Go to the grading screen. Enter some student grades and submit. VERIFY: Students' grades appear in the list but are NOT marked in red, no lateness information shown in the "Last modified (submission)" column. B) Create an online text assignment, setting the due date to yesterday. VERIFY: "Prevent late submissions" box is shown below the "Due date" field. Log in as as a student and make a submission. Log in as the teacher and go to the grading screen. VERIFY: The student's submission is marked in red, with lateness information shown in the "Last modified (submission)" column..
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      39382

      Description

      In the assignment grading screen, assignments show lines with late submissions in red (and with information re lateness of the submission). However, for offline assignments, the submission date is the date when a grade is entered, which is normally after the deadline. It doesn't make sense to display lateness information here.

      To reproduce: Create an offline assignment and set the due date to yesterday. Go to the grading screen and enter a number of grades. Once saved, the grades will be shown in red.

      Patch to follow.

        Issue Links

          Activity

          Hide
          Henning Bostelmann added a comment -

          Fix for master on Github.

          The fix introduces a method "supports_lateness()" in the assignment_base class, which is overridden in assignment_offline subclass.

          Show
          Henning Bostelmann added a comment - Fix for master on Github. The fix introduces a method "supports_lateness()" in the assignment_base class, which is overridden in assignment_offline subclass.
          Hide
          Michael de Raadt added a comment -

          Thanks for providing a fix for that.

          Show
          Michael de Raadt added a comment - Thanks for providing a fix for that.
          Hide
          Henning Bostelmann added a comment -

          I amended the patch so that it fixes MDL-10716 as well.

          Show
          Henning Bostelmann added a comment - I amended the patch so that it fixes MDL-10716 as well.
          Hide
          Dan Poltawski added a comment -

          Hi Henning,

          Thanks - this looks good and makes sense to me, so i'm submitting it for integration.

          However, in master we are going to have a new assignment module landing very soon in master and this might be conceived as too much for the stable branches so it may be that we are not able to integrate this..

          Show
          Dan Poltawski added a comment - Hi Henning, Thanks - this looks good and makes sense to me, so i'm submitting it for integration. However, in master we are going to have a new assignment module landing very soon in master and this might be conceived as too much for the stable branches so it may be that we are not able to integrate this..
          Hide
          Henning Bostelmann added a comment -

          Hi Dan, thanks for the peer review.

          We've been having users asking about this bug for a while now - it would be great to have the fix integrated, since most sites (in fact, at this time, all sites) are using the "old" assignment module.

          Show
          Henning Bostelmann added a comment - Hi Dan, thanks for the peer review. We've been having users asking about this bug for a while now - it would be great to have the fix integrated, since most sites (in fact, at this time, all sites) are using the "old" assignment module.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (21, 22 & master)

          I've added one extra commit with some minor phpdocs & whitespace fixes.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 & master) I've added one extra commit with some minor phpdocs & whitespace fixes.
          Hide
          Michael de Raadt added a comment -

          Test result: Success.

          Tested in 2.1, 2.2 and master.

          Show
          Michael de Raadt added a comment - Test result: Success. Tested in 2.1, 2.2 and master.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This has been near becoming rejected, because it's not the best code you are able to produce.

          But, luckily, at the end, it has landed and has been spread to all repos out there.

          Many thanks and, don't forget it, keep improving your skills, you can!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: