Moodle
  1. Moodle
  2. MDL-32494

CAS configuration page mis-spellings (MDL-16646 reloaded)

    Details

    • Testing Instructions:
      Hide

      1. Go to "Site Administration >> Plugins >> Authentication >> Manage authenication".
      2. Click on the "CAS Server (SSO)" settings link on the right (no need to activate the plugin).
      3. Check the new spelling and strings.
      4. Profit!

      Show
      1. Go to "Site Administration >> Plugins >> Authentication >> Manage authenication". 2. Click on the "CAS Server (SSO)" settings link on the right (no need to activate the plugin). 3. Check the new spelling and strings. 4. Profit!
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_mdl-16646_master
    • Rank:
      39386

      Description

      As directed in MDL-16646 by Michael, I'm opening a new issue (and proposing a patch for it). Quoting from MDL-16646:

      There are several mis-spellings, grammatical errors, and confusing language on the CAS configuration page.

      1. Version - this currently says "Version of CAS". This is very confusing because what it is really asking for is the protocol version of CAS not the server version. This should say something like "CAS protocol version" The field label should be changed as well to reflect what is really being asked for.

      2.Proxy mode - Currently says "Turn this to 'yes'' if you use CASin proxy-mode" should be something like "Select "Yes" if you use CAS in proxy mode."

      3. Logout CAS - Currently says "Turn this to 'yes'' if tou want to logout from CAS when you deconnect from Moodle" should say something like "Select "Yes" if you want to logout of CAS when you disconnect from Moodle" The field label should be changed to "CAS Logout Option"

      4. Multi-Authentication - Currently says "Turn this to 'yes'' if you want to have multi-authentication (CAS + other authentication)" should say something like "Select "Yes" if you use multiple authentication plug-ins (CAS + other authentication)"

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for persisting with that and providing a patch.

        Show
        Michael de Raadt added a comment - Thanks for persisting with that and providing a patch.
        Hide
        Helen Foster added a comment -

        Iñaki, thanks for your patch. The strings all look great to me, apart from 'CAS Protocol Version' which I think should be 'CAS protocol version' according to http://docs.moodle.org/dev/Coding_style#Language_strings

        Show
        Helen Foster added a comment - Iñaki, thanks for your patch. The strings all look great to me, apart from 'CAS Protocol Version' which I think should be 'CAS protocol version' according to http://docs.moodle.org/dev/Coding_style#Language_strings
        Hide
        Iñaki Arenaza added a comment -

        Thanks Helen

        I'll change the string and will resubmit the changes to github today.

        Show
        Iñaki Arenaza added a comment - Thanks Helen I'll change the string and will resubmit the changes to github today.
        Hide
        Iñaki Arenaza added a comment -

        I have just pushed the changes to github (same branch as before).

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - I have just pushed the changes to github (same branch as before). Saludos. Iñaki.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Thanks Iñaki, i've integrated this now - including to 2.1 and 2.2

        Show
        Dan Poltawski added a comment - Thanks Iñaki, i've integrated this now - including to 2.1 and 2.2
        Hide
        Rossiani Wijaya added a comment -

        This looks good.

        Thanks Inaki.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This looks good. Thanks Inaki. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: