Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
      None

      Description

      Get rid of user setting for course display

      There is no longer need in per-user setting to show only one section in the course (it confused people anyway).

      Remove the control
      delete function course_get_display, course_set_display and their usage,
      DROP TABLE mdl_course_display

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Poltawski added a comment -

            This branch removes this setting and gets the topics/weeks to work without this 'sticky setting'.

            The navigation link to section was removed and navigation links to sections only display when we are in 'display section at a time' mode.

            Show
            Dan Poltawski added a comment - This branch removes this setting and gets the topics/weeks to work without this 'sticky setting'. The navigation link to section was removed and navigation links to sections only display when we are in 'display section at a time' mode.
            Hide
            Dan Poltawski added a comment -

            Hi Petr,

            There are some tests in phpunit_test.php relating to course_display. They are not testing the functionality of course_display, so I was just wondering if they could be replaced by any old table does course_display have a distinctive feature?

            Show
            Dan Poltawski added a comment - Hi Petr, There are some tests in phpunit_test.php relating to course_display. They are not testing the functionality of course_display, so I was just wondering if they could be replaced by any old table does course_display have a distinctive feature?
            Hide
            Petr Skoda added a comment -

            feel free to abuse any other empty table

            Show
            Petr Skoda added a comment - feel free to abuse any other empty table
            Hide
            Martin Dougiamas added a comment -

            Empty table? Such as?

            Show
            Martin Dougiamas added a comment - Empty table? Such as?
            Show
            Dan Poltawski added a comment - Petr, I went for user_preferences: https://github.com/danpoltawski/moodle/commit/67c713ff0f2bebde927af7d5ddc2fdac6ddd602d
            Hide
            Petr Skoda added a comment -

            yes, it is ok

            Show
            Petr Skoda added a comment - yes, it is ok
            Hide
            Dan Poltawski added a comment -

            This has been integrated as part of the pull in MDL-32508

            Show
            Dan Poltawski added a comment - This has been integrated as part of the pull in MDL-32508
            Hide
            Mark Drechsler added a comment -

            Uh, not sure if anyone else has twigged to this, but I know a whole heap of clients who have been using this method to fight the 'scroll of death' for many years, and disappearing this feature will mean that the only way to display only one topic will be to use the single topic display format, right? What happens to people who have built custom navigation into Topic 1 of their course, or a block, and which is a pivotal part of their learning design?

            I hope I'm proved wrong on this, but as someone who has spent a few years working with end users who want as many ways to manage the SoD as possible, this seems like a major mistake in usability to me.

            Thoughts/flames welcome.

            Show
            Mark Drechsler added a comment - Uh, not sure if anyone else has twigged to this, but I know a whole heap of clients who have been using this method to fight the 'scroll of death' for many years, and disappearing this feature will mean that the only way to display only one topic will be to use the single topic display format, right? What happens to people who have built custom navigation into Topic 1 of their course, or a block, and which is a pivotal part of their learning design? I hope I'm proved wrong on this, but as someone who has spent a few years working with end users who want as many ways to manage the SoD as possible, this seems like a major mistake in usability to me. Thoughts/flames welcome.
            Hide
            Dan Poltawski added a comment -

            Hi Mark,

            The 'What happens to people who have built custom navigation into Topic 1 of their course, or a block, and which is a pivotal part of their learning design?' was an oversight, and should be fixed in: MDL-34829

            Show
            Dan Poltawski added a comment - Hi Mark, The 'What happens to people who have built custom navigation into Topic 1 of their course, or a block, and which is a pivotal part of their learning design?' was an oversight, and should be fixed in: MDL-34829

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: