Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Groups
    • Labels:
    • Testing Instructions:
      Hide

      Whilst in a course as an editing teacher or administrator:

      • Navigate to Course administration -> Users -> Groups
      • Create a new group
      • Select the group
      • Open your browser web developer tools:
        • In Chrome, the following settings to the developer tools help: Console: Preserve log upon navigation, and in the 'Scripts' tab, click the 'Pause on all exceptions' button
      • Click the 'Delete selected group' button
        • Confirm that no errors were displayed in the javascript console
      Show
      Whilst in a course as an editing teacher or administrator: Navigate to Course administration -> Users -> Groups Create a new group Select the group Open your browser web developer tools: In Chrome, the following settings to the developer tools help: Console: Preserve log upon navigation, and in the 'Scripts' tab, click the 'Pause on all exceptions' button Click the 'Delete selected group' button Confirm that no errors were displayed in the javascript console
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32514-master-1

      Description

      Whilst thoroughly testing MDL-32005 before submitting for IR, I came across a weird bug in group/index.php. There's an onClick for the "Delete selected groups" button which calls a function which hasn't existed in nearly five years.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            The JS code for onDeleteGroup() was removed in commit 08103c9364b58ec9ca43eafad29d9f81e1a22b60
            The onClick wasn't

            Show
            dobedobedoh Andrew Nicols added a comment - The JS code for onDeleteGroup() was removed in commit 08103c9364b58ec9ca43eafad29d9f81e1a22b60 The onClick wasn't
            Hide
            dobedobedoh Andrew Nicols added a comment -

            This commit cherry-picks cleanly to all stable branches

            Show
            dobedobedoh Andrew Nicols added a comment - This commit cherry-picks cleanly to all stable branches
            Hide
            poltawski Dan Poltawski added a comment -

            Looks like this came from MDL-9780

            Show
            poltawski Dan Poltawski added a comment - Looks like this came from MDL-9780
            Hide
            poltawski Dan Poltawski added a comment -

            +1

            Show
            poltawski Dan Poltawski added a comment - +1
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Amazing! Integrated, thanks! (21, 22 & master).

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Amazing! Integrated, thanks! (21, 22 & master).
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Looks all good.
            Passing
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Looks all good. Passing Thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This has been near becoming rejected, because it's not the best code you are able to produce.

            But, luckily, at the end, it has landed and has been spread to all repos out there.

            Many thanks and, don't forget it, keep improving your skills, you can!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12